From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B818974E42 for ; Tue, 20 Apr 2021 16:44:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F44924B38 for ; Tue, 20 Apr 2021 16:43:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C6C8D24B30 for ; Tue, 20 Apr 2021 16:43:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B9DC94280D for ; Tue, 20 Apr 2021 16:35:46 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 20 Apr 2021 16:35:45 +0200 Message-Id: <20210420143545.11022-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH manager] ui: qemu/Config: disable xtermjs and spice until status is loaded X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 14:44:26 -0000 We enable/disable spice/xtermjs for the console button in the 'load' callback of the statusstore, depending on the vms capabilities, but until the first load there, the only safe option is novnc. So we have to disable xtermjs and spice on start, else a click on the button might open a window that cannot connect to the vm. a forum user probably triggered this: https://forum.proxmox.com/threads/unable-to-find-serial-interface-console-problem.87705 Signed-off-by: Dominik Csapak --- www/manager6/qemu/Config.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index 10bf10a4..b5f8cc9c 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -199,6 +199,8 @@ Ext.define('PVE.qemu.Config', { disabled: !caps.vms['VM.Console'], hidden: template, consoleType: 'kvm', + enableSpice: false, + enableXtermjs: false, consoleName: vm.name, nodename: nodename, vmid: vmid, -- 2.20.1