From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 75E4274D06 for ; Tue, 20 Apr 2021 10:16:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 295C420386 for ; Tue, 20 Apr 2021 10:15:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BB0EA20285 for ; Tue, 20 Apr 2021 10:15:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80BF74287B for ; Tue, 20 Apr 2021 10:15:24 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 20 Apr 2021 10:15:22 +0200 Message-Id: <20210420081523.2704-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210420081523.2704-1-d.csapak@proxmox.com> References: <20210420081523.2704-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.156 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v4 8/9] ui: ceph/Pools: improve number checking for target_size X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 08:16:02 -0000 the field gives us a string, so the second condition could never be true, instead parse to a float instead Signed-off-by: Dominik Csapak --- www/manager6/ceph/Pool.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 236ed0bc..45333f4d 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js @@ -161,15 +161,20 @@ Ext.define('PVE.CephPoolInputPanel', { } }); - if (Ext.isNumber(values.target_size) && values.target_size !== 0) { - values.target_size = values.target_size*1024*1024*1024; + let target_size = Number.parseFloat(values.target_size); + + if (Ext.isNumber(target_size) && target_size !== 0) { + values.target_size = (target_size*1024*1024*1024).toFixed(0); } + return values; }, setValues: function(values) { - if (Ext.isNumber(values.target_size) && values.target_size !== 0) { - values.target_size = values.target_size/1024/1024/1024; + let target_size = Number.parseFloat(values.target_size); + + if (Ext.isNumber(target_size) && target_size !== 0) { + values.target_size = target_size/1024/1024/1024; } this.callParent([values]); -- 2.20.1