From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 439F27295F for ; Tue, 13 Apr 2021 13:00:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37A0A29D8F for ; Tue, 13 Apr 2021 13:00:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A95C929D80 for ; Tue, 13 Apr 2021 13:00:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 764B845A5D for ; Tue, 13 Apr 2021 13:00:07 +0200 (CEST) Date: Tue, 13 Apr 2021 13:00:06 +0200 From: Stoiko Ivanov To: Oguz Bektas Cc: Proxmox VE development discussion Message-ID: <20210413130006.4dac276d@rosa.proxmox.com> In-Reply-To: <20210412142838.1332059-1-o.bektas@proxmox.com> References: <20210412142838.1332059-1-o.bektas@proxmox.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH installer] highlight focused button with dark orange X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 11:00:39 -0000 Thanks for the patch! can see that it could help users, who (have to) navigate the installer with a keyboard... gave it a (very quick) spin with the check-pve make-target - in general it seems ok to me one thing that does not look too nice to me is the +/- buttons for integer entry (click on Options in the HD selection window) - maybe those could be a bit more toned down (only change the foreground in that case) On Mon, 12 Apr 2021 16:28:38 +0200 Oguz Bektas wrote: > idea was from community forum [0] > > arbitrary css can be used to style the installer, for now just add the > highlight feature. > > [0]: > https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440 > > Signed-off-by: Oguz Bektas > --- > proxinstall | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/proxinstall b/proxinstall > index 03f6ec7..e79f0c6 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -25,6 +25,13 @@ use POSIX ":sys_wait_h"; > > use ProxmoxInstallerSetup; > > +my $css_provider = Gtk3::CssProvider->new(); > +my $display = Gtk3::Gdk::Display::get_default; > +my $screen = Gtk3::Gdk::Display::get_default_screen($display); > +Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600); > +my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}"; > +$css_provider->load_from_data($prox_theme); > + > my $setup = ProxmoxInstallerSetup::setup(); > > my $opt_testmode;