From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E08437289D for ; Tue, 13 Apr 2021 10:24:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBE5A27E09 for ; Tue, 13 Apr 2021 10:24:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2845B27E01 for ; Tue, 13 Apr 2021 10:24:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E513F45A15 for ; Tue, 13 Apr 2021 10:24:21 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 13 Apr 2021 10:24:14 +0200 Message-Id: <20210413082414.32241-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: [pve-devel] [RFC qemu-server] avoid setting lun number for drives when pvscsi controller is used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 08:24:52 -0000 Reported in the community forum[0]. In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun property is set to 0. This means that in our stack, one cannot have multiple disks and use 'scsihw: pvscsi' currently, as kvm would fail with bad scsi device lun: 1 Instead of increasing the lun number, increase the scsi-id, as we already do for lsi.* (in hw/scsi/lsi53c895a.c the max_lun property is also 0). [0]: https://forum.proxmox.com/threads/kvm-bad-scsi-device-lun-1.84318/ Signed-off-by: Fabian Ebner --- I'm not experienced in this area, so not at all sure if this is the proper solution/workaround. PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fdb2ac9..4ce663b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1451,7 +1451,7 @@ sub print_drivedevice_full { } } - if (!$conf->{scsihw} || ($conf->{scsihw} =~ m/^lsi/)){ + if (!$conf->{scsihw} || $conf->{scsihw} =~ m/^lsi/ || $conf->{scsihw} eq 'pvscsi') { $device = "scsi-$devicetype,bus=$controller_prefix$controller.0,scsi-id=$unit"; } else { $device = "scsi-$devicetype,bus=$controller_prefix$controller.0,channel=0,scsi-id=0" -- 2.20.1