From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 981787256B; Mon, 12 Apr 2021 17:33:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9118A210A5; Mon, 12 Apr 2021 17:33:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D83A42109B; Mon, 12 Apr 2021 17:32:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A593645A19; Mon, 12 Apr 2021 17:32:59 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Mon, 12 Apr 2021 17:32:51 +0200 Message-Id: <20210412153252.22652-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.012 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/2] FileBrowser: allow downloading root folder and simplify code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 15:33:00 -0000 Signed-off-by: Stefan Reiter --- Smoke tested by downloading an entire container archive as zip, extracting and checking the files. If there was a reason for this to be disabled let me know. Based on my previous series to move the FileBrowser to the widget toolkit: https://lists.proxmox.com/pipermail/pbs-devel/2021-April/002590.html Depends on the proxmox-backup patch to work correctly. src/window/FileBrowser.js | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js index d8e75f4..7d82b01 100644 --- a/src/window/FileBrowser.js +++ b/src/window/FileBrowser.js @@ -98,23 +98,7 @@ Ext.define("Proxmox.window.FileBrowser", { if (!selection || selection.length < 1) return; let data = selection[0].data; - - let canDownload = false; - if (view.downloadUrl) { - switch (data.type) { - case 'h': - case 'f': - canDownload = true; - break; - case 'd': - if (data.depth > 1) { - canDownload = true; - } - break; - default: break; - } - } - + let canDownload = view.downloadUrl && ['h', 'f', 'd'].indexOf(data.type) !== -1; me.lookup('downloadBtn').setDisabled(!canDownload); }, -- 2.20.1