From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6F09871778 for ; Thu, 8 Apr 2021 14:41:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62DC81B4E1 for ; Thu, 8 Apr 2021 14:41:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 981581B4D9 for ; Thu, 8 Apr 2021 14:41:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 65869459F5 for ; Thu, 8 Apr 2021 14:41:33 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Thu, 8 Apr 2021 14:41:18 +0200 Message-Id: <20210408124118.10185-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH widget-toolkit] toolkit: override email VType validation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 12:41:34 -0000 ExtJS email validation regex has a length limit of 6 on the TLD. This breaks some new gTLDs (e.g. .systems) Override the validation function and verify against the EMAILRE from PVE::Tools (used for 'e-mail' in JSONSchema) Reported in our community forum: https://forum.proxmox.com/threads/acme-account-register-dialog-does-not-accept-gtlds.87305/ Quickly tested (by using test@test.systems(|test)? on my test-installation) Signed-off-by: Stoiko Ivanov --- src/Toolkit.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Toolkit.js b/src/Toolkit.js index b011c38..6ae31ed 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -182,6 +182,11 @@ Ext.apply(Ext.form.field.VTypes, { }, passwordText: gettext('Passwords do not match'), + + email: function(value) { + let emailre = /^[\w+~-]+(\.[\w+~-]+)*@[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)$/; + return emailre.test(value); + }, }); // Firefox 52+ Touchscreen bug -- 2.20.1