From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57BB67126A for ; Wed, 7 Apr 2021 16:22:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BF6C117BC for ; Wed, 7 Apr 2021 16:22:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3CB9C117AA for ; Wed, 7 Apr 2021 16:22:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F00794592C for ; Wed, 7 Apr 2021 16:22:19 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 7 Apr 2021 16:22:17 +0200 Message-Id: <20210407142218.29156-3-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210407142218.29156-1-a.lauterer@proxmox.com> References: <20210407142218.29156-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rbdplugin.pm] Subject: [pve-devel] [PATCH v2 storage 2/3] rbd: fix #3286 add namespace support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 14:22:51 -0000 This patch introduces support for Cephs RBD namespaces. A new storage config parameter 'namespace' defines the namespace to be used for the RBD storage. The namespace must already exist in the Ceph cluster as it is not automatically created. The main intention is to use this for external Ceph clusters. With namespaces, each PVE cluster can get its own namespace and will not conflict with other PVE clusters. Signed-off-by: Aaron Lauterer --- v1 -> v2: use `defined` to check if a namespace if configured instead of evaluating the value which would wrongly evaluate to false if the pool would be called '0'. Thx @Thomas for pointing this out. much less changes since the 'centralize rbd path concatenation' patch took care of most instances. removed empty new lines that I did not catch in the previous version rvc -> v1: add --namespace parameter centrally in sub $build_cmd. All commands except one (rbd unmap) support it. To handle commands that don't support it, a hash with them was introduced. In a few places paths (FS, Ceph hierarchy) are needed. These are the places scattered throughout the plugin where the namespace is inserted if it is configured. PVE/Storage/RBDPlugin.pm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 421539f..02950be 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -25,6 +25,8 @@ my $get_parent_image_name = sub { my $get_rbd_path = sub { my ($scfg, $volume) = @_; my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd'; + + return "${pool}/$scfg->{namespace}/${volume}" if defined($scfg->{namespace}); return "${pool}/${volume}"; }; @@ -36,6 +38,14 @@ my $build_cmd = sub { my $cmd = [$binary, '-p', $pool]; + # some subcommands will fail if the --namespace parameter is present + my $no_namespace_parameter = { + unmap => 1, + }; + + push @$cmd, '--namespace', $scfg->{namespace} + if ($scfg->{namespace} && !$no_namespace_parameter->{$op}); + push @$cmd, '-c', $cmd_option->{ceph_conf} if ($cmd_option->{ceph_conf}); push @$cmd, '-m', $cmd_option->{mon_host} if ($cmd_option->{mon_host}); push @$cmd, '--auth_supported', $cmd_option->{auth_supported} if ($cmd_option->{auth_supported}); @@ -152,6 +162,7 @@ sub rbd_ls { my $cmd = &$rbd_cmd($scfg, $storeid, 'ls', '-l', '--format', 'json'); my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd'; + $pool .= "/$scfg->{namespace}" if defined($scfg->{namespace}); my $raw = ''; my $parser = sub { $raw .= shift }; @@ -279,6 +290,10 @@ sub properties { description => "Pool.", type => 'string', }, + namespace=> { + description => "RBD Namespace.", + type => 'string', + }, username => { description => "RBD Id.", type => 'string', @@ -300,6 +315,7 @@ sub options { disable => { optional => 1 }, monhost => { optional => 1}, pool => { optional => 1 }, + namespace => { optional => 1 }, username => { optional => 1 }, content => { optional => 1 }, krbd => { optional => 1 }, @@ -368,6 +384,7 @@ sub find_free_diskname { my ($class, $storeid, $scfg, $vmid, $fmt, $add_fmt_suffix) = @_; my $cmd = &$rbd_cmd($scfg, $storeid, 'ls'); + my $disk_list = []; my $parser = sub { @@ -498,6 +515,7 @@ sub free_image { my ($vtype, $name, $vmid, undef, undef, undef) = $class->parse_volname($volname); + my $snaps = rbd_ls_snap($scfg, $storeid, $name); foreach my $snap (keys %$snaps) { if ($snaps->{$snap}->{protected}) { @@ -522,6 +540,7 @@ sub list_images { $cache->{rbd} = rbd_ls($scfg, $storeid) if !$cache->{rbd}; my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd'; + $pool .= "/$scfg->{namespace}" if defined($scfg->{namespace}); my $res = []; -- 2.20.1