From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9EEBA70F11 for ; Tue, 6 Apr 2021 15:24:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8281F2DECC for ; Tue, 6 Apr 2021 15:23:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E80FC2DEBF for ; Tue, 6 Apr 2021 15:23:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B4651459D1 for ; Tue, 6 Apr 2021 15:23:40 +0200 (CEST) Date: Tue, 6 Apr 2021 15:23:39 +0200 From: Wolfgang Bumiller To: Oguz Bektas Cc: pve-devel@lists.proxmox.com Message-ID: <20210406132339.rjlilroplm2ytq5h@olga.proxmox.com> References: <20210406115616.421007-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406115616.421007-1-o.bektas@proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH container] pct: fix edge case for 'pct push' with root uid/gid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 13:24:12 -0000 applied On Tue, Apr 06, 2021 at 01:56:16PM +0200, Oguz Bektas wrote: > we should check if the variable is defined in the end (because root > uid:gid is 0:0, this causes perl to get confused and die, eventhough the > uid:gid was obtained correctly) > > reported here: > https://forum.proxmox.com/threads/pct-push-fails-to-get-uid-gid.87065/ > > Signed-off-by: Oguz Bektas > --- > src/PVE/CLI/pct.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm > index 69faf8d..6b63915 100755 > --- a/src/PVE/CLI/pct.pm > +++ b/src/PVE/CLI/pct.pm > @@ -422,14 +422,16 @@ sub create_file { > if ($user =~ /^\d+$/) { > $uid = int($user); > } else { > - $uid = getpwnam($user) or die "failed to get uid for: $user\n" > + $uid = getpwnam($user); > + die "failed to get uid for: $user\n" if !defined($uid); > } > } > if (defined($group)) { > if ($group =~ /^\d+$/) { > $gid = int($group); > } else { > - $gid = getgrnam($group) or die "failed to get gid for: $group\n" > + $gid = getgrnam($group); > + die "failed to get gid for: $group\n" if !defined($gid); > } > } > > -- > 2.20.1