From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54C2570F00 for ; Tue, 6 Apr 2021 13:59:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B2112D0AF for ; Tue, 6 Apr 2021 13:59:22 +0200 (CEST) Received: from gaia.proxmox.com (unknown [94.136.29.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9CB052D0A5 for ; Tue, 6 Apr 2021 13:59:20 +0200 (CEST) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 136BuK1L421193; Tue, 6 Apr 2021 13:56:20 +0200 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 136BuK8W421192; Tue, 6 Apr 2021 13:56:20 +0200 From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Tue, 6 Apr 2021 13:56:16 +0200 Message-Id: <20210406115616.421007-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL 0.044 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH container] pct: fix edge case for 'pct push' with root uid/gid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 11:59:52 -0000 we should check if the variable is defined in the end (because root uid:gid is 0:0, this causes perl to get confused and die, eventhough the uid:gid was obtained correctly) reported here: https://forum.proxmox.com/threads/pct-push-fails-to-get-uid-gid.87065/ Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 69faf8d..6b63915 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -422,14 +422,16 @@ sub create_file { if ($user =~ /^\d+$/) { $uid = int($user); } else { - $uid = getpwnam($user) or die "failed to get uid for: $user\n" + $uid = getpwnam($user); + die "failed to get uid for: $user\n" if !defined($uid); } } if (defined($group)) { if ($group =~ /^\d+$/) { $gid = int($group); } else { - $gid = getgrnam($group) or die "failed to get gid for: $group\n" + $gid = getgrnam($group); + die "failed to get gid for: $group\n" if !defined($gid); } } -- 2.20.1