From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 61A3669FF1 for ; Wed, 24 Mar 2021 14:23:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 574FFA3C8 for ; Wed, 24 Mar 2021 14:23:20 +0100 (CET) Received: from gaia.proxmox.com (unknown [94.136.29.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 97EF2A3C0 for ; Wed, 24 Mar 2021 14:23:19 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 12ODKeeX593125; Wed, 24 Mar 2021 14:20:40 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 12ODKepw593124; Wed, 24 Mar 2021 14:20:40 +0100 From: Oguz Bektas To: pve-devel@lists.proxmox.com, pve-devel@pve.proxmox.com Date: Wed, 24 Mar 2021 14:20:36 +0100 Message-Id: <20210324132036.592880-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <99c76ae4-0810-f44d-25c4-3cdf8ce28dc0@proxmox.com> References: <99c76ae4-0810-f44d-25c4-3cdf8ce28dc0@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.222 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [perl.org, daemon.pm] Subject: [pve-devel] [PATCH v4 common 1/3] daemon: listen also on ipv6 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 13:23:50 -0000 see [0] when we set 'Domain' to PF_INET6 by default, it will prefer IPv6. since we don't set 'V6Only' it will also listen on IPv4 interfaces. 'Family' parameter isn't needed anymore. this change depends on the changes in pve-manager and pve-http-server to work correctly. [0]: https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR Signed-off-by: Oguz Bektas --- v3->v4: * remove $family parameter src/PVE/Daemon.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 64f8126..905635a 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -799,7 +799,7 @@ sub register_status_command { # some useful helper sub create_reusable_socket { - my ($self, $port, $host, $family) = @_; + my ($self, $port, $host) = @_; die "no port specifed" if !$port; @@ -820,10 +820,10 @@ sub create_reusable_socket { } else { $socket = IO::Socket::IP->new( - LocalAddr => $host, + Domain => PF_INET6, + LocalHost => $host, LocalPort => $port, Listen => SOMAXCONN, - Family => $family, Proto => 'tcp', GetAddrInfoFlags => 0, ReuseAddr => 1) || -- 2.20.1