From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB442694B9 for ; Mon, 22 Mar 2021 15:04:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A07E5247CF for ; Mon, 22 Mar 2021 15:03:31 +0100 (CET) Received: from gaia.proxmox.com (unknown [94.136.29.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E3FDF247B9 for ; Mon, 22 Mar 2021 15:03:30 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 12ME0lTn763528; Mon, 22 Mar 2021 15:00:47 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 12ME0lV9763527; Mon, 22 Mar 2021 15:00:47 +0100 From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 22 Mar 2021 15:00:44 +0100 Message-Id: <20210322140045.763332-3-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210322140045.763332-1-o.bektas@proxmox.com> References: <20210322140045.763332-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH v3 manager 2/3] proxy: allow setting LISTEN_IP for pveproxy and spiceproxy X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 14:04:01 -0000 the $host variable is set to "::0" by default to listen on wildcard (with 'Domain' => PF_INET6). if 'LISTEN_IP' is defined in /etc/default/pveproxy, that IP will be used instead. Signed-off-by: Oguz Bektas --- PVE/Service/pveproxy.pm | 4 ++-- PVE/Service/spiceproxy.pm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index 571a6bf5..4ecd442a 100755 --- a/PVE/Service/pveproxy.pm +++ b/PVE/Service/pveproxy.pm @@ -69,8 +69,8 @@ sub init { my $lockfh = IO::File->new(">>${accept_lock_fn}") || die "unable to open lock file '${accept_lock_fn}' - $!\n"; - my $family = PVE::Tools::get_host_address_family($self->{nodename}); - my $socket = $self->create_reusable_socket(8006, undef, $family); + my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; + my $socket = $self->create_reusable_socket(8006, $listen_ip); my $dirs = {}; diff --git a/PVE/Service/spiceproxy.pm b/PVE/Service/spiceproxy.pm index f8e06b60..24be0ed7 100755 --- a/PVE/Service/spiceproxy.pm +++ b/PVE/Service/spiceproxy.pm @@ -39,8 +39,8 @@ sub init { my $lockfh = IO::File->new(">>${accept_lock_fn}") || die "unable to open lock file '${accept_lock_fn}' - $!\n"; - my $family = PVE::Tools::get_host_address_family($self->{nodename}); - my $socket = $self->create_reusable_socket(3128, undef, $family); + my $listen_ip = $proxyconf->{LISTEN_IP} // "::0"; + my $socket = $self->create_reusable_socket(3128, $listen_ip); $self->{server_config} = { keep_alive => 0, -- 2.20.1