From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B8E156B6B1 for ; Wed, 17 Mar 2021 11:19:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF5912C194 for ; Wed, 17 Mar 2021 11:19:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 477182C18C for ; Wed, 17 Mar 2021 11:19:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08D8042774 for ; Wed, 17 Mar 2021 11:19:42 +0100 (CET) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Wed, 17 Mar 2021 11:19:35 +0100 Message-Id: <20210317101935.5112-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 10:19:42 -0000 Only show "not supported by QEMU version" message if we determine that to be the actual cause, just print the error otherwise. Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 5a9ffab..4d171d2 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -490,9 +490,15 @@ sub archive_pbs { }; my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") }; - if (!$qemu_support) { - die "PBS backups are not supported by the running QEMU version. Please make " - . "sure you've installed the latest version and the VM has been restarted.\n"; + my $err = $@; + if (!$qemu_support || $err) { + die "query-proxmox-support returned empty value\n" if !$err; + if ($err =~ m/The command query-proxmox-support has not been found/) { + die "PBS backups are not supported by the running QEMU version. Please make " + . "sure you've installed the latest version and the VM has been restarted.\n"; + } else { + die "QMP command query-proxmox-support failed - $err\n"; + } } my $fs_frozen = $self->qga_fs_freeze($task, $vmid); -- 2.20.1