From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 144E36B66C for ; Wed, 17 Mar 2021 10:47:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E07852B9A2 for ; Wed, 17 Mar 2021 10:47:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7501F2B99A for ; Wed, 17 Mar 2021 10:47:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 36AC7426FA for ; Wed, 17 Mar 2021 10:47:02 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 17 Mar 2021 10:46:58 +0100 Message-Id: <20210317094658.29195-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nfsplugin.pm] Subject: [pve-devel] [PATCH storage] fix #3348: Revert "NFS: avoid using obsolete rpcinfo option" X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 09:47:03 -0000 This reverts commit 816dadb17f8e28d7a0a092c055c0c07b6038e64c. With '-T' one needs to specify either 'tcp' or 'tcp6', and using 'tcp' doesn't work for an IPv6-only server. Simply switch back to using '-t', because $server might also just be a host name, so it's not really worth adding extra code (and calls) to figure out if it's IPv4 or IPv6 beforehand. Signed-off-by: Fabian Ebner --- If preferred, I can send an alternative using rpcinfo -l $server nfs 4 but that requires parsing the output. PVE/Storage/NFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm index cb16864..72e06c2 100644 --- a/PVE/Storage/NFSPlugin.pm +++ b/PVE/Storage/NFSPlugin.pm @@ -166,7 +166,7 @@ sub check_connection { if (defined($opts) && $opts =~ /vers=4.*/) { # nfsv4 uses a pseudo-filesystem always beginning with / # no exports are listed - $cmd = ['/usr/sbin/rpcinfo', '-T', 'tcp', $server, 'nfs', '4']; + $cmd = ['/usr/sbin/rpcinfo', '-t', $server, 'nfs', '4']; } else { $cmd = ['/sbin/showmount', '--no-headers', '--exports', $server]; } -- 2.20.1