From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE37169C43 for ; Fri, 12 Mar 2021 10:50:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB62E31354 for ; Fri, 12 Mar 2021 10:50:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4B63E31343 for ; Fri, 12 Mar 2021 10:50:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0EF9D446E1 for ; Fri, 12 Mar 2021 10:50:31 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 12 Mar 2021 10:50:27 +0100 Message-Id: <20210312095027.19451-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210312095027.19451-1-f.ebner@proxmox.com> References: <20210312095027.19451-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 2/2] tests: zfs: complain when a first sub-test dies X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 09:50:31 -0000 Previously, $count was not increased and no test failure was reported. Signed-off-by: Fabian Ebner --- Found by messing up in the previous patch at first with: my $res = map { $_ => [] } keys %{$ids}; instead of my $res = { map { $_ => [] } keys %{$ids} }; and wondering why it failed in "production", but the test ran through. test/run_test_zfspoolplugin.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 9c5e841..2f63f1b 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@ -2714,7 +2714,10 @@ for (my $i = $start_test; $i <= $end_test; $i++) { eval { $tests->{$i}(); }; - warn $@ if $@; + if (my $err = $@) { + warn $err; + $count++; + } cleanup_zfs(); } -- 2.20.1