From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 918DC696C7 for ; Thu, 11 Mar 2021 11:26:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8977E26973 for ; Thu, 11 Mar 2021 11:26:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5EC5D26940 for ; Thu, 11 Mar 2021 11:26:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2928641E3E for ; Thu, 11 Mar 2021 11:26:54 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 11 Mar 2021 11:26:46 +0100 Message-Id: <20210311102650.6730-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210311102650.6730-1-f.ebner@proxmox.com> References: <20210311102650.6730-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 1/5] ui: avoid errors when 'template' property is not present in guest status X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 10:26:55 -0000 The API doesn't advertise the property as non-optional and it's safer and more in line with the surrounding code. Signed-off-by: Fabian Ebner --- New in v2. Needed for the next two patches to work. www/manager6/lxc/Config.js | 2 +- www/manager6/qemu/Config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 89747a0a..73e34614 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.js @@ -347,7 +347,7 @@ Ext.define('PVE.lxc.Config', { var rec = s.data.get('status'); status = rec ? rec.data.value : 'unknown'; rec = s.data.get('template'); - template = rec.data.value || false; + template = rec ? rec.data.value : false; rec = s.data.get('lock'); lock = rec ? rec.data.value : undefined; } diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index c0c6552c..10bf10a4 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -385,7 +385,7 @@ Ext.define('PVE.qemu.Config', { rec = s.data.get('qmpstatus'); qmpstatus = rec ? rec.data.value : 'unknown'; rec = s.data.get('template'); - template = rec.data.value || false; + template = rec ? rec.data.value : false; rec = s.data.get('lock'); lock = rec ? rec.data.value : undefined; -- 2.20.1