From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56F956B48A for ; Tue, 9 Mar 2021 10:15:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42C98275B1 for ; Tue, 9 Mar 2021 10:15:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C4CDE275A8 for ; Tue, 9 Mar 2021 10:15:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89E5045862 for ; Tue, 9 Mar 2021 10:15:04 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 9 Mar 2021 10:15:00 +0100 Message-Id: <20210309091500.5058-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [record.data] Subject: [pve-devel] [PATCH v2 manager] fix #3301: show currently running QEMU version X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 09:15:35 -0000 in the VM summary page. Signed-off-by: Fabian Ebner --- Changes from v1: * use a separate field instead of attaching it directly to the status. Put it directly below the Status field, because it feels like they belong together. OTOH the information might not be as relevant so maybe it should be further below? I thought about dynamically hiding the field when the VM is not running, but I didn't see an easy way in this case (would need to add some new functionality to the StatusView base class AFAICT). An alternative would be using cbind for running too, but that's not dynamic. Instead, simply use a renderer that checks for running. www/manager6/panel/GuestStatusView.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js index 8dab4c19..acf3b7c5 100644 --- a/www/manager6/panel/GuestStatusView.js +++ b/www/manager6/panel/GuestStatusView.js @@ -43,6 +43,24 @@ Ext.define('PVE.panel.GuestStatusView', { return text; }, }, + { + itemId: 'qemuversion', + xtype: 'pveInfoWidget', + title: gettext('QEMU version'), + iconCls: 'fa fa-info fa-fw', + printBar: false, + multiField: true, + renderer: function(record) { + if (record.data.status !== 'running') { + return gettext('not running'); + } + return record.data['running-qemu'] || 'N/A'; + }, + cbind: { + hidden: '{!isQemu}', + disabled: '{!isQemu}', + }, + }, { itemId: 'hamanaged', iconCls: 'fa fa-heartbeat fa-fw', -- 2.20.1