From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 32D2B6AFCC for ; Mon, 8 Mar 2021 11:02:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22A3F1CBDB for ; Mon, 8 Mar 2021 11:02:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7F8D11CBBA for ; Mon, 8 Mar 2021 11:02:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 43BFC41DD8 for ; Mon, 8 Mar 2021 11:02:01 +0100 (CET) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Mon, 8 Mar 2021 11:01:51 +0100 Message-Id: <20210308100151.7886-5-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210308100151.7886-1-s.reiter@proxmox.com> References: <20210308100151.7886-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 5/5] ui/hardware: extend machine renderer to show pinned Windows versions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 10:02:03 -0000 The default is not just "i440fx", this hides the fact that the version will be pinned to 5.1, unless one deliberately opens the editor. Signed-off-by: Stefan Reiter --- www/manager6/qemu/HardwareView.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 470baa46..98352e3f 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -159,7 +159,14 @@ Ext.define('PVE.qemu.HardwareView', { never_delete: true, group: 6, defaultValue: '', - renderer: PVE.Utils.render_qemu_machine, + renderer: function(value, metaData, record, rowIndex, colIndex, store, pending) { + let ostype = me.getObjectValue('ostype', undefined, pending); + if (PVE.Utils.is_windows(ostype) && + (!value || value === 'pc' || value === 'q35')) { + return value === 'q35' ? 'pc-q35-5.1' : 'pc-i440fx-5.1'; + } + return PVE.Utils.render_qemu_machine(value); + }, }, scsihw: { header: gettext('SCSI Controller'), @@ -203,6 +210,9 @@ Ext.define('PVE.qemu.HardwareView', { shares: { visible: false, }, + ostype: { + visible: false, + }, }; PVE.Utils.forEachBus(undefined, function(type, id) { -- 2.20.1