From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C54D1690D3 for ; Mon, 1 Mar 2021 14:59:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B4B9E20E7A for ; Mon, 1 Mar 2021 14:59:05 +0100 (CET) Received: from gaia.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 53BBC20E71 for ; Mon, 1 Mar 2021 14:59:05 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 121DupkO564361; Mon, 1 Mar 2021 14:56:51 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 121DupRG564353; Mon, 1 Mar 2021 14:56:51 +0100 From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 1 Mar 2021 14:56:49 +0100 Message-Id: <20210301135649.564191-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.322 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.001 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH storage] fix #3203: report smart status correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 13:59:35 -0000 if the -a option isn't passed, -H might report a failing disk as 'PASSED' even when the disk might be in a corrupted state. Signed-off-by: Oguz Bektas --- PVE/Diskmanage.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 64bb813..d3c3365 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -95,8 +95,9 @@ sub get_smart_data { or die "failed to get nvme controller device for $disk\n"); } - my $cmd = [$SMARTCTL, '-H']; - push @$cmd, '-A', '-f', 'brief' if !$healthonly; + my $cmd = [$SMARTCTL]; + push @$cmd, '-H' if $healthonly; + push @$cmd, '-a', '-A', '-f', 'brief' if !$healthonly; push @$cmd, $disk; eval { -- 2.20.1