From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AE1768EC5 for ; Mon, 1 Mar 2021 10:43:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B47C1CEFE for ; Mon, 1 Mar 2021 10:42:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 103F21CEF3 for ; Mon, 1 Mar 2021 10:42:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D0FB141D09 for ; Mon, 1 Mar 2021 10:42:28 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 1 Mar 2021 10:42:24 +0100 Message-Id: <20210301094224.22203-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] fix #3324: clone disk: use larger blocksize for EFI disk when possible X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 09:43:00 -0000 Moving to Ceph is very slow when bs=1. Instead, use the biggest possible power of two <= 1024. At the moment our EFI image sizes are multiples of 1024, so just using 1024 wouldn't be a problem, but this feels more future-proof. Signed-off-by: Fabian Ebner --- I did not see an way for 'qemu-img dd' to use a larger blocksize while still specifying the exact total size if it is not a multiple of the blocksize. PVE/QemuServer.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f401baf..e579cdf 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6991,7 +6991,15 @@ sub clone_disk { # that is given by the OVMF_VARS.fd my $src_path = PVE::Storage::path($storecfg, $drive->{file}); my $dst_path = PVE::Storage::path($storecfg, $newvolid); - run_command(['qemu-img', 'dd', '-n', '-O', $dst_format, "bs=1", "count=$size", + + # Ceph doesn't like too small blocksize, see bug #3324 + my $bs = 1; + while ($bs < $size && $bs < 1024 && $size % $bs == 0) { + $bs *= 2; + } + my $count = $size / $bs; + + run_command(['qemu-img', 'dd', '-n', '-O', $dst_format, "bs=$bs", "count=$count", "if=$src_path", "of=$dst_path"]); } else { qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit); -- 2.20.1