From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0EDDE69EC0 for ; Thu, 25 Feb 2021 12:03:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF00C33415 for ; Thu, 25 Feb 2021 12:03:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D813733408 for ; Thu, 25 Feb 2021 12:03:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9F37641CEC for ; Thu, 25 Feb 2021 12:03:17 +0100 (CET) Date: Thu, 25 Feb 2021 12:01:06 +0100 From: Oguz Bektas To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <20210225110106.GB11907@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Thomas Lamprecht , Proxmox VE development discussion References: <20210225101650.272444-1-o.bektas@proxmox.com> <5429d2b2-a0a8-f9f7-6d2a-57f59408efdc@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5429d2b2-a0a8-f9f7-6d2a-57f59408efdc@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.513 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] mention file path for ct debug log X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2021 11:03:49 -0000 On Thu, Feb 25, 2021 at 11:58:53AM +0100, Thomas Lamprecht wrote: > On 25.02.21 11:16, Oguz Bektas wrote: > > Signed-off-by: Oguz Bektas > > --- > > src/PVE/LXC.pm | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > > index bae236b..db9a2ee 100644 > > --- a/src/PVE/LXC.pm > > +++ b/src/PVE/LXC.pm > > @@ -2306,7 +2306,10 @@ sub vm_start { > > monitor_start($monitor_socket, $vmid) if defined($monitor_socket); > > > > # if debug is requested, print the log it also when the start succeeded > > - print_ct_stderr_log($vmid) if $is_debug; > > + if ($is_debug) { > > + print_ct_stderr_log($vmid); > > + print "debug log saved in: /run/pve/ct-$vmid.stderr\n"; > > why though? all of that file is printed so what use is it to see the > path (with just the same content one just gets printed). hmm i was thinking it'd be easier to attach on the forum threads. > > Also it's not really saved, this is just in memory. I'd not print that... then maybe we can just save it somewhere and print that? > > > + } > > }; > > if (my $err = $@) { > > unlink $skiplock_flag_fn; > > >