From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8F38F6C381 for ; Mon, 22 Feb 2021 11:16:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85EBB2D8C7 for ; Mon, 22 Feb 2021 11:16:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0D1F82D8B6 for ; Mon, 22 Feb 2021 11:16:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C41EB42BC1 for ; Mon, 22 Feb 2021 11:16:26 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 22 Feb 2021 11:16:26 +0100 Message-Id: <20210222101626.19240-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210222101626.19240-1-a.lauterer@proxmox.com> References: <20210222101626.19240-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/2] ui: FirewallRules: Add tooltip to comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 10:16:57 -0000 The comment columns might not be wide enough for longer comments. Since it is the most right columns, it can be tricky to grab the right pixel to drag it wider. A tooltip that shows up on hover should be okay. Signed-off-by: Aaron Lauterer --- As an additional patch as I realized that the comment column can be a bit hard to use on smaller screens. www/manager6/grid/FirewallRules.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 5a2241a0..f7f304b8 100644 --- a/www/manager6/grid/FirewallRules.js +++ b/www/manager6/grid/FirewallRules.js @@ -763,8 +763,10 @@ Ext.define('PVE.FirewallRules', { dataIndex: 'comment', flex: 6, renderer: function(value, metaData, record) { - return render_errors('comment', Ext.util.Format.htmlEncode(value), metaData, record); - }, + let comment = render_errors('comment', Ext.util.Format.htmlEncode(value), metaData, record); + return `${comment}`; +}, + }, ); -- 2.20.1