From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 056FC6B3EF for ; Thu, 18 Feb 2021 16:45:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA244101FF for ; Thu, 18 Feb 2021 16:45:22 +0100 (CET) Received: from gaia.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 82425101F6 for ; Thu, 18 Feb 2021 16:45:22 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 11IFhKL62057172; Thu, 18 Feb 2021 16:43:20 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 11IFhKS02057171; Thu, 18 Feb 2021 16:43:20 +0100 From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Thu, 18 Feb 2021 16:43:19 +0100 Message-Id: <20210218154319.2057075-3-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210218154319.2057075-1-o.bektas@proxmox.com> References: <20210218154319.2057075-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.537 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.399 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH v2 manager 2/2] proxy: allow setting LISTEN_IP for pveproxy X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 15:45:23 -0000 to preserve backwards behavior we leave this as 'undef' if it's not configured in /etc/default/pveproxy Signed-off-by: Oguz Bektas --- v1->v2: * use 'undef' as default instead of 0.0.0.0 * s/BIND_IP/LISTEN_IP/g PVE/Service/pveproxy.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index 571a6bf5..ca56bc60 100755 --- a/PVE/Service/pveproxy.pm +++ b/PVE/Service/pveproxy.pm @@ -70,7 +70,8 @@ sub init { die "unable to open lock file '${accept_lock_fn}' - $!\n"; my $family = PVE::Tools::get_host_address_family($self->{nodename}); - my $socket = $self->create_reusable_socket(8006, undef, $family); + my $bind_ip = $proxyconf->{LISTEN_IP} // undef; # default + my $socket = $self->create_reusable_socket(8006, $bind_ip, $family); my $dirs = {}; -- 2.20.1