From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 581626AF89 for ; Wed, 17 Feb 2021 14:32:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 472542285D for ; Wed, 17 Feb 2021 14:32:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9ADA922855 for ; Wed, 17 Feb 2021 14:32:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5FEAF461D4 for ; Wed, 17 Feb 2021 14:32:26 +0100 (CET) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Wed, 17 Feb 2021 14:32:16 +0100 Message-Id: <20210217133216.2470-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [format.pm, proxmox.com] Subject: [pve-devel] [PATCH common] format: fix render_bytes with CLIFormatter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 13:32:57 -0000 CLIFormatter passes in an options hash as a second paramter, which so far was ignored. Now that we treat it as a precision parameter, check if it is a hash and extract the option from it before using it. Otherwise perl puts HASH(0x...) into the format and sprintf chokes. Signed-off-by: Stefan Reiter --- Reported here: https://forum.proxmox.com/threads/bug-found-where-to-post.84407/ I'm getting too used to Rust... src/PVE/Format.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Format.pm b/src/PVE/Format.pm index ed86029..366bc16 100644 --- a/src/PVE/Format.pm +++ b/src/PVE/Format.pm @@ -64,6 +64,8 @@ sub render_fraction_as_percentage { sub render_bytes { my ($value, $precision) = @_; + $precision = $precision->{precision} if ref($precision) eq 'HASH'; + my @units = qw(B KiB MiB GiB TiB PiB); my $max_unit = 0; -- 2.20.1