From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4C1E9695D9 for ; Fri, 12 Feb 2021 16:57:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 49BA42892E for ; Fri, 12 Feb 2021 16:57:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6C8152890C for ; Fri, 12 Feb 2021 16:57:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3CDBB46254 for ; Fri, 12 Feb 2021 16:57:52 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 12 Feb 2021 16:57:49 +0100 Message-Id: <20210212155751.16045-3-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210212155751.16045-1-a.lauterer@proxmox.com> References: <20210212155751.16045-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 3/4] ui: qemu/HardwareView: eslint: enforce "no-shadow" rule X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2021 15:57:54 -0000 By removing global vars 'i' and 'confid' and declaring them with let in the needed context. 'i' wasn't necessary but had to be touched anyway. Signed-off-by: Aaron Lauterer --- v2: removed the global definitions for i and confid and declared them locally where needed. www/manager6/qemu/HardwareView.js | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 730a44d9..036bfa26 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -45,7 +45,6 @@ Ext.define('PVE.qemu.HardwareView', { initComponent: function() { var me = this; - var i, confid; var nodename = me.pveSelNode.data.node; if (!nodename) { @@ -220,7 +219,7 @@ Ext.define('PVE.qemu.HardwareView', { }; PVE.Utils.forEachBus(undefined, function(type, id) { - var confid = type + id; + let confid = type + id; rows[confid] = { group: 10, iconCls: 'hdd-o', @@ -232,8 +231,8 @@ Ext.define('PVE.qemu.HardwareView', { cloudheader: gettext('CloudInit Drive') + ' (' + confid + ')', }; }); - for (i = 0; i < PVE.Utils.hardware_counts.net; i++) { - confid = "net" + i.toString(); + for (let i = 0; i < PVE.Utils.hardware_counts.net; i++) { + let confid = "net" + i.toString(); rows[confid] = { group: 15, order: i, @@ -250,8 +249,8 @@ Ext.define('PVE.qemu.HardwareView', { never_delete: !caps.vms['VM.Config.Disk'], header: gettext('EFI Disk'), }; - for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) { - confid = "usb" + i.toString(); + for (let i = 0; i < PVE.Utils.hardware_counts.usb; i++) { + let confid = "usb" + i.toString(); rows[confid] = { group: 25, order: i, @@ -261,8 +260,8 @@ Ext.define('PVE.qemu.HardwareView', { header: gettext('USB Device') + ' (' + confid + ')', }; } - for (i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) { - confid = "hostpci" + i.toString(); + for (let i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) { + let confid = "hostpci" + i.toString(); rows[confid] = { group: 30, order: i, @@ -272,8 +271,8 @@ Ext.define('PVE.qemu.HardwareView', { header: gettext('PCI Device') + ' (' + confid + ')', }; } - for (i = 0; i < PVE.Utils.hardware_counts.serial; i++) { - confid = "serial" + i.toString(); + for (let i = 0; i < PVE.Utils.hardware_counts.serial; i++) { + let confid = "serial" + i.toString(); rows[confid] = { group: 35, order: i, @@ -289,7 +288,7 @@ Ext.define('PVE.qemu.HardwareView', { never_delete: !caps.vms['VM.Config.HWType'], header: gettext('Audio Device'), }; - for (i = 0; i < 256; i++) { + for (let i = 0; i < 256; i++) { rows["unused" + i.toString()] = { group: 99, order: i, @@ -531,8 +530,8 @@ Ext.define('PVE.qemu.HardwareView', { let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type]; var set_button_status = function() { - var sm = me.getSelectionModel(); - var rec = sm.getSelection()[0]; + var selection_model = me.getSelectionModel(); + var rec = selection_model.getSelection()[0]; // en/disable hardwarebuttons counts = {}; -- 2.20.1