From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A79A62C7B for ; Mon, 8 Feb 2021 13:42:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8175D21C85 for ; Mon, 8 Feb 2021 13:42:07 +0100 (CET) Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8043721C53 for ; Mon, 8 Feb 2021 13:42:06 +0100 (CET) Received: by dev.dominic.proxmox.com (Postfix, from userid 0) id 5A6F220272; Mon, 8 Feb 2021 13:42:06 +0100 (CET) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Mon, 8 Feb 2021 13:41:34 +0100 Message-Id: <20210208124137.125375-2-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208124137.125375-1-d.jaeger@proxmox.com> References: <20210208124137.125375-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.357 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH widget-toolkit 2/5] vlan edit: Forbid blank vlan raw device X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 12:42:07 -0000 Users certainly have to insert a vlan raw device when the textfield is enabled. Currently, they only see `invalid network interface name "` when submitting. Forbidding the blank field shows the problem earlier. Signed-off-by: Dominic Jäger --- src/node/NetworkEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index b2d1077..35edc31 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -128,6 +128,7 @@ Ext.define('Proxmox.node.NetworkEdit', { name: 'vlan-raw-device', value: me.vlanrawdevicevalue, disabled: me.disablevlanrawdevice, + allowBlank: false, }); column2.push({ -- 2.20.1