From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.reiter@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 6538F62C8E
for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 12:17:33 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5CC7920C30
for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 12:17:03 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 464B620C11
for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 12:17:02 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F3F145635
for <pve-devel@lists.proxmox.com>; Mon, 8 Feb 2021 12:17:02 +0100 (CET)
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 8 Feb 2021 12:15:10 +0100
Message-Id: <20210208111512.27281-4-s.reiter@proxmox.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210208111512.27281-1-s.reiter@proxmox.com>
References: <20210208111512.27281-1-s.reiter@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.037 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH v2 qemu-server 4/6] savevm: periodically print
progress
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 08 Feb 2021 11:17:33 -0000
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
v2:
* rename helper
* return tuple
* use 'total-time'
* improve messages
PVE/QemuConfig.pm | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 3f4605f..0c4b8fd 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -14,6 +14,7 @@ use PVE::QemuServer;
use PVE::QemuServer::Machine;
use PVE::Storage;
use PVE::Tools;
+use PVE::Format qw(render_bytes render_duration);
use base qw(PVE::AbstractConfig);
@@ -280,14 +281,25 @@ sub __snapshot_create_vol_snapshots_hook {
PVE::Storage::activate_volumes($storecfg, [$snap->{vmstate}]);
mon_cmd($vmid, "savevm-start", statefile => $path);
+ print "saving VM state and RAM\n";
+ my $render_state = sub {
+ my ($stat) = @_;
+ my $b = render_bytes($stat->{bytes});
+ my $t = render_duration($stat->{'total-time'} / 1000);
+ return ($b, $t);
+ };
for(;;) {
my $stat = mon_cmd($vmid, "query-savevm");
if (!$stat->{status}) {
die "savevm not active\n";
} elsif ($stat->{status} eq 'active') {
sleep(1);
+ my ($b, $t) = $render_state->($stat);
+ print "$b in $t\n";
next;
} elsif ($stat->{status} eq 'completed') {
+ my ($b, $t) = $render_state->($stat);
+ print "completed savevm in $t, saved $b\n";
last;
} else {
die "query-savevm returned status '$stat->{status}'\n";
--
2.20.1