From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E09536C95B for ; Mon, 1 Feb 2021 15:21:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE6F1253A4 for ; Mon, 1 Feb 2021 15:21:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 80BF82537D for ; Mon, 1 Feb 2021 15:21:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B9D3456E0 for ; Mon, 1 Feb 2021 15:21:32 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 1 Feb 2021 15:21:30 +0100 Message-Id: <20210201142131.30024-7-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210201142131.30024-1-a.lauterer@proxmox.com> References: <20210201142131.30024-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 6/7] ui: qemu/HardwareView: check EFI Disk button permissions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 14:21:33 -0000 Make sure that the `Add EFI Disk` button is disabled if the user does not have the needed permissions. Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 80d6eec1..252a8e72 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -561,6 +561,7 @@ Ext.define('PVE.qemu.HardwareView', { const noSysConsolePerm = !caps.nodes['Sys.Console']; const noVMConfigHWTypePerm = !caps.vms['VM.Config.HWType']; const noVMConfigNetPerm = !caps.vms['VM.Config.Network']; + const noVMConfigDiskPerm = !caps.vms['VM.Config.Disk']; me.down('#addusb').setDisabled(noSysConsolePerm || isAtLimit('usb')); @@ -569,7 +570,7 @@ Ext.define('PVE.qemu.HardwareView', { me.down('#addserial').setDisabled(noVMConfigHWTypePerm || isAtLimit('serial')); me.down('#addnet').setDisabled(noVMConfigNetPerm || isAtLimit('net')); me.down('#addrng').setDisabled(noSysConsolePerm || isAtLimit('rng')); - efidisk_menuitem.setDisabled(isAtLimit('efidisk')); + efidisk_menuitem.setDisabled(noVMConfigDiskPerm || isAtLimit('efidisk')); me.down('#addci').setDisabled(noSysConsolePerm || hasCloudInit); if (!rec) { -- 2.20.1