From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50FC76C989 for ; Mon, 1 Feb 2021 15:21:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F1B92539A for ; Mon, 1 Feb 2021 15:21:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E71C425357 for ; Mon, 1 Feb 2021 15:21:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B379B45D7B for ; Mon, 1 Feb 2021 15:21:31 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 1 Feb 2021 15:21:24 +0100 Message-Id: <20210201142131.30024-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 0/7] ui: qemu/HardwareView: fix GUI permission checks and make eslint happier X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 14:21:33 -0000 This series fixes two permission checks in the HardwareView panel: * Add -> EFI Disk button * Edit button for CDROM drives to only show them as enabled if the necessary permissions are available. Additionally it contains a few patches to make eslint happy. Aaron Lauterer (7): ui: qemu/HardwareView: eslint: enforce "no-mixed-operators" rule ui: qemu/HardwareView: eslint: enforce "max-len" rule ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule ui: qemu/HardwareView: eslint: enforce "no-shadow" rule ui: qemu/HardwareView: change heuristic perms to const ui: qemu/HardwareView: check EFI Disk button permissions ui: qemu/HardwareView: add CDROM permission check to edit button www/manager6/qemu/HardwareView.js | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) -- 2.20.1