From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D77769BCB for ; Wed, 20 Jan 2021 11:01:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 884DE2557D for ; Wed, 20 Jan 2021 11:01:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CA4B225540 for ; Wed, 20 Jan 2021 11:01:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8ECAA4609B for ; Wed, 20 Jan 2021 11:01:54 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 20 Jan 2021 11:01:36 +0100 Message-Id: <20210120100143.16268-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [apt.pm] Subject: [pve-devel] [RFC] APT repositories API/UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 10:01:56 -0000 List the configured repositories and have some basic checks for them. Much is still missing, but I'd like to get feedback for a few things: * having distinct API calls for the listing and checking can mean that the list of repositories and the list of warnings are not in sync (when the repository configuration changes in between calls, which admittedly is unlikely). But we could also only have one API call and either always add the warnings or have a flag to do so. There are two warnings that are not associated with a repository though, and those are for not having the enterprise or neither the no-subscription repository configured. But that could be solved by always including the enterprise repository, even if it is not defined in a file (in that case with 'enabled => 0' of course), and associating those two warnings with it. * This also ties in to how to best display the warnings: currently it's just a list at the bottom (will be made more visible of course if that's the approach we opt for), but we could also display warnings directly below the repository they are for by using the RowBody feature. * see individual patches Still missing: * warning should also be there if enterprise repository is configured, but there is no valid subscription * warnings should be more clearly visible * button for switching to newer suite to be used before a major upgrade * that of course requires a writer for the repository files * tests * add to PMG * re-implement in Rust for PBS common: Fabian Ebner (2): add module for APT APT: add extended repositories check src/Makefile | 1 + src/PVE/APT.pm | 398 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 399 insertions(+) create mode 100644 src/PVE/APT.pm manager: Fabian Ebner (3): api: APT: add call to list repositories ui: add panel for listing APT repositories api: APT: add call for repository check PVE/API2/APT.pm | 115 ++++++++++++++++++++++++++++++++++++ www/manager6/node/Config.js | 7 +++ 2 files changed, 122 insertions(+) widget-toolkit: Fabian Ebner (2): add UI for APT repositories APT repositories: show list of warnings src/Makefile | 1 + src/node/APTRepositories.js | 213 ++++++++++++++++++++++++++++++++++++ 2 files changed, 214 insertions(+) create mode 100644 src/node/APTRepositories.js -- 2.20.1