From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 49E3168EBE for ; Fri, 15 Jan 2021 12:50:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35ADA243B9 for ; Fri, 15 Jan 2021 12:49:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6751F243B1 for ; Fri, 15 Jan 2021 12:49:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 328C145795 for ; Fri, 15 Jan 2021 12:49:28 +0100 (CET) From: Mira Limbeck To: pve-devel@lists.proxmox.com Date: Fri, 15 Jan 2021 12:49:24 +0100 Message-Id: <20210115114924.30795-1-m.limbeck@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.254 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server] fix drive-mirror completion with cloudinit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 11:50:00 -0000 On clone_vm when cloning the disks while the VM is running, we use drive-mirror. We skip completion until the last disk, but with a cloudinit disk there's no drive-mirror and so no completion done. If it is the last disk in the hash, we never complete the drive-mirror jobs and no further cloning is possible as there are already active jobs using the disks. To fix it we have to call qemu_drive_mirror_monitor directly in the case of cloudinit when completion is requested and there are jobs defined. Signed-off-by: Mira Limbeck --- PVE/QemuServer.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 54278e5..ae9d6dd 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6965,6 +6965,12 @@ sub clone_disk { PVE::Storage::activate_volumes($storecfg, [$newvolid]); if (drive_is_cloudinit($drive)) { + # when cloning multiple disks (e.g. during clone_vm) it might be the last disk + # if this is the case, we have to complete any block-jobs still there from + # previous drive-mirrors + if (($completion eq 'complete') && (scalar(keys %$jobs) > 0)) { + qemu_drive_mirror_monitor($vmid, $newvmid, $jobs, $completion, $qga); + } goto no_data_clone; } -- 2.20.1