From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6B68767496 for ; Tue, 12 Jan 2021 12:19:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AA4423E49 for ; Tue, 12 Jan 2021 12:18:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A507E23E3F for ; Tue, 12 Jan 2021 12:18:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68D414513C for ; Tue, 12 Jan 2021 12:18:40 +0100 (CET) Date: Tue, 12 Jan 2021 12:17:19 +0100 From: Oguz Bektas To: Proxmox VE development discussion Message-ID: <20210112111719.GA8806@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Proxmox VE development discussion References: <20210112110754.168177-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112110754.168177-1-h.laimer@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.136 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm async close #2315 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 11:19:11 -0000 hi, thanks for the fix :) Tested-by: Oguz Bektas On Tue, Jan 12, 2021 at 12:07:54PM +0100, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > Resize is now done in a task. > > v1 -> v2: pass code that should be executed correctly to fork_worker > > PVE/API2/Qemu.pm | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index e8de4ea..0c5d50c 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -3730,7 +3730,7 @@ __PACKAGE__->register_method({ > }, > }, > }, > - returns => { type => 'null'}, > + returns => { type => 'string'}, > code => sub { > my ($param) = @_; > > @@ -3816,9 +3816,10 @@ __PACKAGE__->register_method({ > > PVE::QemuConfig->write_config($vmid, $conf); > }; > - > - PVE::QemuConfig->lock_config($vmid, $updatefn); > - return; > + my $worker = sub { > + PVE::QemuConfig->lock_config($vmid, $updatefn); > + }; > + return $rpcenv->fork_worker('qmresize', $vmid, $authuser, $worker); > }}); > > __PACKAGE__->register_method({ > -- > 2.20.1 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >