From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E64C467348 for ; Tue, 12 Jan 2021 11:22:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9D9D22B95 for ; Tue, 12 Jan 2021 11:21:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3A95122B7E for ; Tue, 12 Jan 2021 11:21:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E8AEF45F92 for ; Tue, 12 Jan 2021 11:21:57 +0100 (CET) From: Alwin Antreich To: pve-devel@lists.proxmox.com Date: Tue, 12 Jan 2021 11:21:45 +0100 Message-Id: <20210112102153.3215121-3-a.antreich@proxmox.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210112102153.3215121-1-a.antreich@proxmox.com> References: <20210112102153.3215121-1-a.antreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pools.pm] Subject: [pve-devel] [PATCH manager v3 02/10] ceph: setpool, use parameter extraction instead X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 10:22:28 -0000 of the unneeded ref copy for params. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/Pools.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm index fac21301..b9e295f5 100644 --- a/PVE/API2/Ceph/Pools.pm +++ b/PVE/API2/Ceph/Pools.pm @@ -377,15 +377,11 @@ __PACKAGE__->register_method ({ my $rpcenv = PVE::RPCEnvironment::get(); my $authuser = $rpcenv->get_user(); - my $pool = $param->{name}; - my $ceph_param = \%$param; - for my $item ('name', 'node') { - # not ceph parameters - delete $ceph_param->{$item}; - } + my $pool = extract_param($param, 'name'); + my $node = extract_param($param, 'node'); my $worker = sub { - PVE::Ceph::Tools::set_pool($pool, $ceph_param); + PVE::Ceph::Tools::set_pool($pool, $param); }; return $rpcenv->fork_worker('cephsetpool', $pool, $authuser, $worker); -- 2.29.2