From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF64966E5C; Mon, 11 Jan 2021 12:14:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B955419138; Mon, 11 Jan 2021 12:14:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6DDF6190F4; Mon, 11 Jan 2021 12:14:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 39A0845F2F; Mon, 11 Jan 2021 12:14:40 +0100 (CET) From: Stefan Reiter To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Mon, 11 Jan 2021 12:14:03 +0100 Message-Id: <20210111111409.32385-6-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210111111409.32385-1-s.reiter@proxmox.com> References: <20210111111409.32385-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 11:14:41 -0000 Values chosen by fair dice roll, seems to be a good sweet spot on my machine where any less causes performance degradation but any more doesn't really make it go any faster. Keep in mind that those values are per drive in an actual restore. Signed-off-by: Stefan Reiter --- Depends on new proxmox-backup. src/restore.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/restore.rs b/src/restore.rs index 24983dd..fdb3d1c 100644 --- a/src/restore.rs +++ b/src/restore.rs @@ -218,15 +218,16 @@ impl RestoreTask { let index = client.download_fixed_index(&manifest, &archive_name).await?; let archive_size = index.index_bytes(); - let most_used = index.find_most_used_chunks(8); + let most_used = index.find_most_used_chunks(16); // 64 MB most used cache let file_info = manifest.lookup_file_info(&archive_name)?; - let chunk_reader = RemoteChunkReader::new( + let chunk_reader = RemoteChunkReader::new_lru_cached( Arc::clone(&client), self.crypt_config.clone(), file_info.chunk_crypt_mode(), most_used, + 64, // 256 MB LRU cache ); let reader = AsyncIndexReader::new(index, chunk_reader); -- 2.20.1