From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9FFCE666A0 for ; Thu, 7 Jan 2021 16:24:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E8B11EAF6 for ; Thu, 7 Jan 2021 16:24:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7BBAB1EAEC for ; Thu, 7 Jan 2021 16:24:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C07445CF4 for ; Thu, 7 Jan 2021 16:24:25 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 7 Jan 2021 16:24:24 +0100 Message-Id: <20210107152424.31185-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common] SectionConfig: check_value: add broader boolean parsing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 15:24:56 -0000 In other config parsers we already allow the use of yes,on,true and their negative counterparts for booleans. Adding the JSONSchema::parse_boolean here aligns this behavior to all the config files that use SectionConfig. Signed-off-by: Aaron Lauterer --- SectionConfig is used for quite a few "internal" config files. One major example that users edit manually quite a bit is the storage.cfg src/PVE/SectionConfig.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm index af0af03..5cf0a6f 100644 --- a/src/PVE/SectionConfig.pm +++ b/src/PVE/SectionConfig.pm @@ -248,6 +248,8 @@ sub check_value { $value = 1 if $ct eq 'boolean' && !defined($value); + $value = PVE::JSONSchema::parse_boolean($value) if $ct eq 'boolean'; + die "got undefined value\n" if !defined($value); die "property contains a line feed\n" if $value =~ m/[\n\r]/; -- 2.20.1