From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50CAB65F5E for ; Tue, 5 Jan 2021 10:35:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE6E62582C for ; Tue, 5 Jan 2021 10:35:49 +0100 (CET) Received: from kvmformation1.odiso.net (globalOdiso.M6Lille.odiso.net [89.248.211.242]) by firstgate.proxmox.com (Proxmox) with ESMTP id 956E4254CB for ; Tue, 5 Jan 2021 10:35:37 +0100 (CET) Received: by kvmformation1.odiso.net (Postfix, from userid 0) id 72363168B9D; Tue, 5 Jan 2021 10:35:37 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Tue, 5 Jan 2021 10:35:29 +0100 Message-Id: <20210105093536.1727641-9-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210105093536.1727641-1-aderumier@odiso.com> References: <20210105093536.1727641-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.138 Adjusted score from AWL reputation of From: address HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.287 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [phpipamplugin.pm, netboxplugin.pm, plugin.pm] Subject: [pve-devel] [PATCH pve-network 08/15] ipams: add noerr param X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 09:35:50 -0000 Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 24 +++++++++++------------ PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 27 +++++++++++++------------- PVE/Network/SDN/Ipams/Plugin.pm | 12 ++++++------ 3 files changed, 31 insertions(+), 32 deletions(-) diff --git a/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/PVE/Network/SDN/Ipams/NetboxPlugin.pm index eae2e59..5a03f39 100644 --- a/PVE/Network/SDN/Ipams/NetboxPlugin.pm +++ b/PVE/Network/SDN/Ipams/NetboxPlugin.pm @@ -28,7 +28,7 @@ sub options { # Plugin implementation sub add_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; my $cidr = $subnet->{cidr}; my $gateway = $subnet->{gateway}; @@ -47,14 +47,14 @@ sub add_subnet { my $result = PVE::Network::SDN::api_request("POST", "$url/ipam/prefixes/", $headers, $params); }; if ($@) { - die "error add subnet to ipam: $@"; + die "error add subnet to ipam: $@" if !$noerr; } } } sub del_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; my $cidr = $subnet->{cidr}; my $url = $plugin_config->{url}; @@ -71,13 +71,13 @@ sub del_subnet { PVE::Network::SDN::api_request("DELETE", "$url/ipam/prefixes/$internalid/", $headers); }; if ($@) { - die "error deleting subnet from ipam: $@"; + die "error deleting subnet from ipam: $@" if !$noerr; } } sub add_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; my $mask = $subnet->{mask}; my $url = $plugin_config->{url}; @@ -93,12 +93,12 @@ sub add_ip { }; if ($@) { - die "error add subnet ip to ipam: ip already exist: $@"; + die "error add subnet ip to ipam: ip already exist: $@" if !$noerr; } } sub update_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; my $mask = $subnet->{mask}; my $url = $plugin_config->{url}; @@ -116,12 +116,12 @@ sub update_ip { PVE::Network::SDN::api_request("PATCH", "$url/ipam/ip-addresses/$ip_id/", $headers, $params); }; if ($@) { - die "error update ip $ip : $@"; + die "error update ip $ip : $@" if !$noerr; } } sub add_next_freeip { - my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description, $noerr) = @_; my $cidr = $subnet->{cidr}; @@ -141,14 +141,14 @@ sub add_next_freeip { }; if ($@) { - die "can't find free ip in subnet $cidr: $@"; + die "can't find free ip in subnet $cidr: $@" if !$noerr; } return $ip; } sub del_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $noerr) = @_; return if !$ip; @@ -163,7 +163,7 @@ sub del_ip { PVE::Network::SDN::api_request("DELETE", "$url/ipam/ip-addresses/$ip_id/", $headers); }; if ($@) { - die "error delete ip $ip : $@"; + die "error delete ip $ip : $@" if !$noerr; } } diff --git a/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm b/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm index 235d553..ed66ea9 100644 --- a/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm +++ b/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm @@ -38,7 +38,7 @@ sub options { # Plugin implementation sub add_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; my $cidr = $subnet->{cidr}; my $network = $subnet->{network}; @@ -55,7 +55,6 @@ sub add_subnet { #create subnet if (!$internalid) { - my $params = { subnet => $network, mask => $mask, sectionId => $section, @@ -65,14 +64,14 @@ sub add_subnet { PVE::Network::SDN::api_request("POST", "$url/subnets/", $headers, $params); }; if ($@) { - die "error add subnet to ipam: $@"; + die "error add subnet to ipam: $@" if !$noerr; } } } sub del_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; my $cidr = $subnet->{cidr}; my $url = $plugin_config->{url}; @@ -89,13 +88,13 @@ sub del_subnet { PVE::Network::SDN::api_request("DELETE", "$url/subnets/$internalid", $headers); }; if ($@) { - die "error deleting subnet from ipam: $@"; + die "error deleting subnet from ipam: $@" if !$noerr; } } sub add_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; my $cidr = $subnet->{cidr}; my $url = $plugin_config->{url}; @@ -118,12 +117,12 @@ sub add_ip { }; if ($@) { - die "error add subnet ip to ipam: ip $ip already exist: $@"; + die "error add subnet ip to ipam: ip $ip already exist: $@" if !$noerr; } } sub update_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; my $cidr = $subnet->{cidr}; my $url = $plugin_config->{url}; @@ -146,12 +145,12 @@ sub update_ip { }; if ($@) { - die "ipam: error update subnet ip $ip: $@"; + die "ipam: error update subnet ip $ip: $@" if !$noerr; } } sub add_next_freeip { - my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description, $noerr) = @_; my $cidr = $subnet->{cidr}; my $mask = $subnet->{mask}; @@ -175,14 +174,14 @@ sub add_next_freeip { }; if ($@) { - die "can't find free ip in subnet $cidr: $@"; + die "can't find free ip in subnet $cidr: $@" if !$noerr; } - return "$ip/$mask"; + return "$ip/$mask" if $ip && $mask; } sub del_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $noerr) = @_; return if !$ip; @@ -197,7 +196,7 @@ sub del_ip { PVE::Network::SDN::api_request("DELETE", "$url/addresses/$ip_id", $headers); }; if ($@) { - die "error delete ip $ip: $@"; + die "error delete ip $ip: $@" if !$noerr; } } diff --git a/PVE/Network/SDN/Ipams/Plugin.pm b/PVE/Network/SDN/Ipams/Plugin.pm index a4c7dcb..c96eeda 100644 --- a/PVE/Network/SDN/Ipams/Plugin.pm +++ b/PVE/Network/SDN/Ipams/Plugin.pm @@ -67,25 +67,25 @@ sub parse_section_header { sub add_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; die "please implement inside plugin"; } sub del_subnet { - my ($class, $plugin_config, $subnetid, $subnet) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $noerr) = @_; die "please implement inside plugin"; } sub add_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; die "please implement inside plugin"; } sub update_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $hostname, $mac, $description, $is_gateway, $noerr) = @_; # only update ip attributes (mac,hostname,..). Don't change the ip addresses itself, as some ipam # don't allow ip address change without del/add @@ -93,13 +93,13 @@ sub update_ip { } sub add_next_freeip { - my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $hostname, $mac, $description, $noerr) = @_; die "please implement inside plugin"; } sub del_ip { - my ($class, $plugin_config, $subnetid, $subnet, $ip) = @_; + my ($class, $plugin_config, $subnetid, $subnet, $ip, $noerr) = @_; die "please implement inside plugin"; } -- 2.20.1