From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C51A265F53 for ; Tue, 5 Jan 2021 10:35:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C9CD255DD for ; Tue, 5 Jan 2021 10:35:45 +0100 (CET) Received: from kvmformation1.odiso.net (globalOdiso.M6Lille.odiso.net [89.248.211.242]) by firstgate.proxmox.com (Proxmox) with ESMTP id AAE63254D6 for ; Tue, 5 Jan 2021 10:35:37 +0100 (CET) Received: by kvmformation1.odiso.net (Postfix, from userid 0) id A3A9B168BA1; Tue, 5 Jan 2021 10:35:37 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Tue, 5 Jan 2021 10:35:36 +0100 Message-Id: <20210105093536.1727641-16-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210105093536.1727641-1-aderumier@odiso.com> References: <20210105093536.1727641-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.138 Adjusted score from AWL reputation of From: address HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.287 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnets.pm, pveplugin.pm, powerdnsplugin.pm] Subject: [pve-devel] [PATCH pve-network 15/15] fix coding style NetAddr::IP->new X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 09:35:47 -0000 Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 2 +- PVE/Network/SDN/Ipams/PVEPlugin.pm | 2 +- PVE/Network/SDN/Subnets.pm | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/Network/SDN/Dns/PowerdnsPlugin.pm b/PVE/Network/SDN/Dns/PowerdnsPlugin.pm index 339ac28..096d131 100644 --- a/PVE/Network/SDN/Dns/PowerdnsPlugin.pm +++ b/PVE/Network/SDN/Dns/PowerdnsPlugin.pm @@ -237,7 +237,7 @@ sub get_reversedns_zone { if (Net::IP::ip_is_ipv4($ip)) { my ($ipblock1, $ipblock2, $ipblock3, $ipblock4) = split(/\./, $ip); - my $ipv4 = new NetAddr::IP($cidr); + my $ipv4 = NetAddr::IP->new($cidr); #private addresse #powerdns built-in private zone : serve-rfc1918 if($ipv4->is_rfc1918()) { if ($ipblock1 == 192) { diff --git a/PVE/Network/SDN/Ipams/PVEPlugin.pm b/PVE/Network/SDN/Ipams/PVEPlugin.pm index 2527850..7e2fb77 100644 --- a/PVE/Network/SDN/Ipams/PVEPlugin.pm +++ b/PVE/Network/SDN/Ipams/PVEPlugin.pm @@ -131,7 +131,7 @@ sub add_next_freeip { die "cannot find free IP in subnet '$cidr'\n" if defined($dbsubnet->{ips}->{$network}); $freeip = $network; } else { - my $iplist = new NetAddr::IP($cidr); + my $iplist = NetAddr::IP->new($cidr); my $broadcast = $iplist->broadcast(); while(1) { diff --git a/PVE/Network/SDN/Subnets.pm b/PVE/Network/SDN/Subnets.pm index 34b3450..0cbf5fd 100644 --- a/PVE/Network/SDN/Subnets.pm +++ b/PVE/Network/SDN/Subnets.pm @@ -234,7 +234,7 @@ sub add_ip { return if !$subnet || !$ip; - my $ipaddr = new NetAddr::IP($ip); + my $ipaddr = NetAddr::IP->new($ip); $ip = $ipaddr->canon(); my $ipamid = $zone->{ipam}; @@ -281,7 +281,7 @@ sub update_ip { return if !$subnet || !$ip; - my $ipaddr = new NetAddr::IP($ip); + my $ipaddr = NetAddr::IP->new($ip); $ip = $ipaddr->canon(); my $ipamid = $zone->{ipam}; @@ -325,7 +325,7 @@ sub del_ip { return if !$subnet || !$ip; - my $ipaddr = new NetAddr::IP($ip); + my $ipaddr = NetAddr::IP->new($ip); $ip = $ipaddr->canon(); my $ipamid = $zone->{ipam}; -- 2.20.1