From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BEFD065F21 for ; Tue, 5 Jan 2021 10:35:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ACB8225525 for ; Tue, 5 Jan 2021 10:35:41 +0100 (CET) Received: from kvmformation1.odiso.net (globalOdiso.M6Lille.odiso.net [89.248.211.242]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87BBB254C4 for ; Tue, 5 Jan 2021 10:35:37 +0100 (CET) Received: by kvmformation1.odiso.net (Postfix, from userid 0) id 3F861D2597; Tue, 5 Jan 2021 10:35:37 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Tue, 5 Jan 2021 10:35:21 +0100 Message-Id: <20210105093536.1727641-1-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.140 Adjusted score from AWL reputation of From: address HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.287 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnetplugin.pm, powerdnsplugin.pm, vnets.pm, mail-archive.com, subnets.pm, plugin.pm, netboxplugin.pm, phpipamplugin.pm, pveplugin.pm, sdn.pm, proxmox.com] Subject: [pve-devel] [PATCH pve-network 00/15] bugfix && unit tests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 09:35:41 -0000 Hello everybody and Happy new year ! This add unit tests for ipams, dns, subnets and some bugfixes detected with them. for external ipam/dns api, I'm testing only the expected http query with param. I think it should be enough. I have retested all plugins, all methods, I don't have detected bug anymore. I have send a new pve-container patches serie too. (no more in RFC, I think the patch is ok now). I'll try to look at qemu support now. Small reminder of other related patches: pve-cluster: [PATCH V5 pve-cluster 0/5] sdn : add subnets management https://lists.proxmox.com/pipermail/pve-devel/2020-September/045284.html pve-common: INotify: add support for dummy interfaces type (this is a small patch for ebgp loopback/dummy interface support) https://www.mail-archive.com/pve-devel@lists.proxmox.com/msg01755.html pve-docs: [PATCH pve-docs] update sdn documentation https://lists.proxmox.com/pipermail/pve-devel/2020-November/046246.html pve-manager: [PATCH v10 pve-manager 00/19] sdn: add subnets management https://lists.proxmox.com/pipermail/pve-devel/2021-January/046589.html pve-container: [PATCH pve-container] add ipam support https://lists.proxmox.com/pipermail/pve-devel/2021-January/046609.html Alexandre Derumier (15): sdn: pending_config: initialize empty pending key ipams: add mac address ipam: add update_ip dns/ipam : move api_request helper to sdn module subnets: fix del_ip rollback dns: add update record && fix powerdns ipam: phpipam: rename get_internal to get_prefix_id (like netbox) ipams: add noerr param tests: add ipams tests dns: add noerr param tests: add dns tests subnets: convert dns private function to public sub subnets: add add_subnet/del_subnet tests: add subnets tests fix coding style NetAddr::IP->new PVE/API2/Network/SDN/Subnets.pm | 19 +- PVE/Network/SDN.pm | 49 +++- PVE/Network/SDN/Dns/Plugin.pm | 57 ++-- PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 119 ++++++-- PVE/Network/SDN/Ipams/NetboxPlugin.pm | 61 ++-- PVE/Network/SDN/Ipams/PVEPlugin.pm | 11 +- PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 80 +++-- PVE/Network/SDN/Ipams/Plugin.pm | 64 ++-- PVE/Network/SDN/SubnetPlugin.pm | 9 +- PVE/Network/SDN/Subnets.pm | 132 ++++++--- PVE/Network/SDN/Vnets.pm | 49 ++-- test/Makefile | 11 +- test/dns/powerdns/dns_config | 10 + .../expected.add_a_multiple_record.ipv4 | 13 + .../expected.add_a_multiple_record.ipv6 | 13 + test/dns/powerdns/expected.add_a_record.ipv4 | 12 + test/dns/powerdns/expected.add_a_record.ipv6 | 13 + .../dns/powerdns/expected.add_ptr_record.ipv4 | 13 + .../dns/powerdns/expected.add_ptr_record.ipv6 | 12 + .../expected.del_a_multiple_record.ipv4 | 13 + .../expected.del_a_multiple_record.ipv6 | 12 + test/dns/powerdns/expected.del_a_record.ipv4 | 13 + test/dns/powerdns/expected.del_a_record.ipv6 | 12 + .../dns/powerdns/expected.del_ptr_record.ipv4 | 12 + .../dns/powerdns/expected.del_ptr_record.ipv6 | 13 + test/dns/powerdns/expected.verify_zone | 12 + test/dns/powerdns/sdn_config | 20 ++ test/ipams/netbox/expected.add_ip | 9 + test/ipams/netbox/expected.add_next_freeip | 9 + test/ipams/netbox/expected.add_subnet | 9 + test/ipams/netbox/expected.del_ip | 9 + test/ipams/netbox/expected.del_subnet | 9 + test/ipams/netbox/expected.update_ip | 9 + test/ipams/netbox/ipam_config | 18 ++ test/ipams/netbox/sdn_config | 20 ++ test/ipams/phpipam/expected.add_ip | 12 + test/ipams/phpipam/expected.add_next_freeip | 12 + test/ipams/phpipam/expected.add_subnet | 12 + test/ipams/phpipam/expected.del_ip | 12 + test/ipams/phpipam/expected.del_subnet | 12 + test/ipams/phpipam/expected.update_ip | 12 + test/ipams/phpipam/ipam_config | 18 ++ test/ipams/phpipam/sdn_config | 20 ++ test/run_test_dns.pl | 271 +++++++++++++++++ test/run_test_ipams.pl | 181 ++++++++++++ test/run_test_subnets.pl | 273 ++++++++++++++++++ test/subnets/ipv4/ipam_config | 18 ++ test/subnets/ipv4/sdn_config | 20 ++ test/subnets/ipv6/ipam_config | 18 ++ test/subnets/ipv6/sdn_config | 20 ++ 50 files changed, 1642 insertions(+), 215 deletions(-) create mode 100644 test/dns/powerdns/dns_config create mode 100644 test/dns/powerdns/expected.add_a_multiple_record.ipv4 create mode 100644 test/dns/powerdns/expected.add_a_multiple_record.ipv6 create mode 100644 test/dns/powerdns/expected.add_a_record.ipv4 create mode 100644 test/dns/powerdns/expected.add_a_record.ipv6 create mode 100644 test/dns/powerdns/expected.add_ptr_record.ipv4 create mode 100644 test/dns/powerdns/expected.add_ptr_record.ipv6 create mode 100644 test/dns/powerdns/expected.del_a_multiple_record.ipv4 create mode 100644 test/dns/powerdns/expected.del_a_multiple_record.ipv6 create mode 100644 test/dns/powerdns/expected.del_a_record.ipv4 create mode 100644 test/dns/powerdns/expected.del_a_record.ipv6 create mode 100644 test/dns/powerdns/expected.del_ptr_record.ipv4 create mode 100644 test/dns/powerdns/expected.del_ptr_record.ipv6 create mode 100644 test/dns/powerdns/expected.verify_zone create mode 100644 test/dns/powerdns/sdn_config create mode 100644 test/ipams/netbox/expected.add_ip create mode 100644 test/ipams/netbox/expected.add_next_freeip create mode 100644 test/ipams/netbox/expected.add_subnet create mode 100644 test/ipams/netbox/expected.del_ip create mode 100644 test/ipams/netbox/expected.del_subnet create mode 100644 test/ipams/netbox/expected.update_ip create mode 100644 test/ipams/netbox/ipam_config create mode 100644 test/ipams/netbox/sdn_config create mode 100644 test/ipams/phpipam/expected.add_ip create mode 100644 test/ipams/phpipam/expected.add_next_freeip create mode 100644 test/ipams/phpipam/expected.add_subnet create mode 100644 test/ipams/phpipam/expected.del_ip create mode 100644 test/ipams/phpipam/expected.del_subnet create mode 100644 test/ipams/phpipam/expected.update_ip create mode 100644 test/ipams/phpipam/ipam_config create mode 100644 test/ipams/phpipam/sdn_config create mode 100755 test/run_test_dns.pl create mode 100755 test/run_test_ipams.pl create mode 100755 test/run_test_subnets.pl create mode 100644 test/subnets/ipv4/ipam_config create mode 100644 test/subnets/ipv4/sdn_config create mode 100644 test/subnets/ipv6/ipam_config create mode 100644 test/subnets/ipv6/sdn_config -- 2.20.1