From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B47C9629AE for ; Mon, 21 Dec 2020 14:49:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7B7C204D5 for ; Mon, 21 Dec 2020 14:48:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 358D0204A0 for ; Mon, 21 Dec 2020 14:48:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF5EC453B4 for ; Mon, 21 Dec 2020 14:48:24 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 21 Dec 2020 14:48:18 +0100 Message-Id: <20201221134820.24038-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201221134820.24038-1-f.ebner@proxmox.com> References: <20201221134820.24038-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/5] vzdump: fix error format for errors coming from storage_info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 13:49:01 -0000 Errors from storage_info() are newline-terminated, because perl would append the line number otherwise. Chomp those errors, because sendmail() relies on the presence of a newline to decide if it's multiple problems or only one. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 3b864514..d6f9709b 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -498,6 +498,7 @@ sub new { if ($opts->{storage}) { my $info = eval { storage_info ($opts->{storage}) }; if (my $err = $@) { + chomp($err); $errors .= "could not get storage information for '$opts->{storage}': $err"; } else { $opts->{dumpdir} = $info->{dumpdir}; -- 2.20.1