From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 671D26BC06 for ; Mon, 14 Dec 2020 09:59:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 586F0143D3 for ; Mon, 14 Dec 2020 09:59:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 92EF5143BF for ; Mon, 14 Dec 2020 09:59:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 57A9F43E41 for ; Mon, 14 Dec 2020 09:59:53 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 14 Dec 2020 09:59:52 +0100 Message-Id: <20201214085952.30932-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve_flutter_frontend] main: add check to show welcome screen only when no server configured X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 08:59:54 -0000 This additional check will make sure that people who have been using the app already do not get to see the welcome screen. In that situation we also want to make sure that we set the shared pref for the welcome screen to the same state as if it has been seen. Signed-off-by: Aaron Lauterer --- I am still unsure if we shouldn't just show the welcome screen to everyone at least once but that might annoy quite a lot of people though :/ So I prepared this patch should we decide against it. It needs the following patches applied first [0] The slightly weird formatting of the if clause is caused by the dart auto formatter. [0] https://lists.proxmox.com/pipermail/pve-devel/2020-December/046451.html lib/main.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/main.dart b/lib/main.dart index 57ad39c..4b490e3 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -149,10 +149,13 @@ class MyApp extends StatelessWidget { builder: (context) => PveSplashScreen(), ); } - if (sharedPreferences.getBool('showWelcomeScreen') ?? true) { + if (sharedPreferences.getBool('showWelcomeScreen') ?? + true && !sharedPreferences.containsKey('ProxmoxLoginList')) { return MaterialPageRoute( builder: (context) => PveWelcome(), ); + } else if (!sharedPreferences.containsKey('showWelcomeScreen')) { + sharedPreferences.setBool('showWelcomeScreen', false); } if (authbloc.state.value is Unauthenticated || -- 2.20.1