From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 03DEE69D4A for ; Mon, 7 Dec 2020 16:16:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE13427597 for ; Mon, 7 Dec 2020 16:16:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7CB2C27583 for ; Mon, 7 Dec 2020 16:16:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4240744E50 for ; Mon, 7 Dec 2020 16:16:09 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Date: Mon, 7 Dec 2020 16:16:04 +0100 Message-Id: <20201207151604.2207598-2-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201207151604.2207598-1-t.lamprecht@proxmox.com> References: <20201207151604.2207598-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH storage 2/2] nfs and cifs: implement backup notes helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 15:16:13 -0000 reuse the one from DirPlugin by directing the call to it, but with the actual $class. This should stay stable, as we provide an ABI and try to always use $class->helpers. Signed-off-by: Thomas Lamprecht --- PVE/Storage/CIFSPlugin.pm | 9 +++++++++ PVE/Storage/NFSPlugin.pm | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 36339db..be06cc7 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -284,4 +284,13 @@ sub check_connection { return 1; } +sub get_volume_notes { + my $class = shift; + PVE::Storage::DirPlugin::get_volume_notes($class, @_); +} +sub update_volume_notes { + my $class = shift; + PVE::Storage::DirPlugin::update_volume_notes($class, @_); +} + 1; diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm index f8d7e68..e8e27c0 100644 --- a/PVE/Storage/NFSPlugin.pm +++ b/PVE/Storage/NFSPlugin.pm @@ -171,4 +171,13 @@ sub check_connection { return 1; } +sub get_volume_notes { + my $class = shift; + PVE::Storage::DirPlugin::get_volume_notes($class, @_); +} +sub update_volume_notes { + my $class = shift; + PVE::Storage::DirPlugin::update_volume_notes($class, @_); +} + 1; -- 2.20.1