From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 93D3E69CEF for ; Mon, 7 Dec 2020 15:37:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8AA5626FB4 for ; Mon, 7 Dec 2020 15:37:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7FDCB26FAA for ; Mon, 7 Dec 2020 15:37:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4316744E22 for ; Mon, 7 Dec 2020 15:37:08 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 7 Dec 2020 15:37:07 +0100 Message-Id: <20201207143707.18456-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.293 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] status/plugin: do not test connection if disabled X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 14:37:09 -0000 so that if one disables the plugin (e.g. because it is offline), it will work even when the server is not reachable Signed-off-by: Dominik Csapak --- if my other series is ok, i'll rebase either this, or my other series, depending what gets applied first ;) PVE/Status/Plugin.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm index c3e0bec1..040b4538 100644 --- a/PVE/Status/Plugin.pm +++ b/PVE/Status/Plugin.pm @@ -129,6 +129,9 @@ sub send { sub test_connection { my ($class, $cfg) = @_; + # do not check connection for disabled plugins + return if $cfg->{disable}; + my $conn = $class->_connect($cfg); $class->_disconnect($conn); } -- 2.20.1