From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <w.bumiller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 0C0ED628D3
 for <pve-devel@lists.proxmox.com>; Tue, 24 Nov 2020 11:45:43 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 02857A5CD
 for <pve-devel@lists.proxmox.com>; Tue, 24 Nov 2020 11:45:43 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 92580A5C3
 for <pve-devel@lists.proxmox.com>; Tue, 24 Nov 2020 11:45:42 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5B435404AC
 for <pve-devel@lists.proxmox.com>; Tue, 24 Nov 2020 11:45:42 +0100 (CET)
Date: Tue, 24 Nov 2020 11:45:41 +0100
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <20201124104541.jw6l4fcmmiva3kf3@wobu-vie.proxmox.com>
References: <20201030094228.53423-1-aderumier@odiso.com>
 <20201030094228.53423-4-aderumier@odiso.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201030094228.53423-4-aderumier@odiso.com>
User-Agent: NeoMutt/20180716
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.024 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [cgroup.pm]
Subject: Re: [pve-devel] [PATCH pve-container 3/3] cgroup: get_subdir:
 return cgroupv2 path for undef controller
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2020 10:45:43 -0000

On Fri, Oct 30, 2020 at 10:42:28AM +0100, Alexandre Derumier wrote:
> ---
>  src/PVE/LXC/CGroup.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/LXC/CGroup.pm b/src/PVE/LXC/CGroup.pm
> index 19562c2..74d84c4 100644
> --- a/src/PVE/LXC/CGroup.pm
> +++ b/src/PVE/LXC/CGroup.pm
> @@ -35,6 +35,7 @@ sub get_subdir {
>      my $path = $entry->{$kind};
>  
>      return $path if defined $path;
> +    return "/lxc/$self->{vmid}" if !$controller;

Why exactly are you doing this? `get_cgroup_path` should work with an
undef $controller value. Also, this ignores the $limiting parameter (and
the main point for using the command socket was to not hardcode paths at
all)
So what kind of problem did you run into there?

>  
>      $path = PVE::LXC::Command::get_cgroup_path(
>  	$self->{vmid},
> -- 
> 2.20.1