From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BEE7862772; Tue, 24 Nov 2020 10:09:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCDDE88E0; Tue, 24 Nov 2020 10:09:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 82D5188B2; Tue, 24 Nov 2020 10:09:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3208C44071; Tue, 24 Nov 2020 10:09:38 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Tue, 24 Nov 2020 10:09:34 +0100 Message-Id: <20201124090936.21810-7-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201124090936.21810-1-d.csapak@proxmox.com> References: <20201124090936.21810-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.320 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 1/3] ui: change comment column to notes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 09:09:40 -0000 Signed-off-by: Dominik Csapak --- www/manager6/grid/BackupView.js | 4 ++-- www/manager6/storage/Browser.js | 2 +- www/manager6/storage/ContentView.js | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js index ec0b60b2..191b2e3f 100644 --- a/www/manager6/grid/BackupView.js +++ b/www/manager6/grid/BackupView.js @@ -238,8 +238,8 @@ Ext.define('PVE.grid.BackupView', { dataIndex: 'volid' }, { - header: gettext('Comment'), - dataIndex: 'comment', + header: gettext('Notes'), + dataIndex: 'notes', flex: 1, renderer: Ext.htmlEncode, }, diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 64c492d8..6efa0e65 100644 --- a/www/manager6/storage/Browser.js +++ b/www/manager6/storage/Browser.js @@ -53,7 +53,7 @@ Ext.define('PVE.storage.Browser', { title: gettext('Backups'), iconCls: 'fa fa-floppy-o', itemId: 'contentBackup', - hasCommentColumn: true, + hasNotesColumn: true, }); } if (contents.includes('images')) { diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index eb487553..a5e4cdee 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/ContentView.js @@ -333,11 +333,11 @@ Ext.define('PVE.storage.ContentView', { renderer: PVE.Utils.render_storage_content, dataIndex: 'text', }, - 'comment': { - header: gettext('Comment'), + 'notes': { + header: gettext('Notes'), flex: 1, renderer: Ext.htmlEncode, - dataIndex: 'comment', + dataIndex: 'notes', }, 'date': { header: gettext('Date'), @@ -359,8 +359,8 @@ Ext.define('PVE.storage.ContentView', { if (me.hideColumns) { me.hideColumns.forEach(key => delete availableColumns[key]); - } else if (!me.hasCommentColumn) { - delete availableColumns.comment; + } else if (!me.hasNotesColumn) { + delete availableColumns.notes; } const columns = Object.values(availableColumns); @@ -381,7 +381,7 @@ Ext.define('PVE.storage.ContentView', { extend: 'Ext.data.Model', fields: [ 'volid', 'content', 'format', 'size', 'used', 'vmid', - 'channel', 'id', 'lun', 'comment', 'verification', + 'channel', 'id', 'lun', 'notes', 'verification', { name: 'text', convert: function(value, record) { -- 2.20.1