From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3ABAA62854; Tue, 24 Nov 2020 10:10:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3107E88D8; Tue, 24 Nov 2020 10:09:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EE0CE8897; Tue, 24 Nov 2020 10:09:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ADBE444368; Tue, 24 Nov 2020 10:09:37 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Tue, 24 Nov 2020 10:09:28 +0100 Message-Id: <20201124090936.21810-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.324 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, storage.pm, plugin.pm, proxmox-backup-client.rs, pbsplugin.pm, content.pm, snapshot.rs, dirplugin.pm] Subject: [pve-devel] [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 09:10:10 -0000 implement editing/showing notes from pve side for directory and pbs storages this series technically consists of a breaking api change (comments -> notes) in content listing, but since we only just built packages with the relevant commits, this should be ok... i also omitted the suggested 'snapshot list' part of proxmox-backup but will look into implementing an invisible alias for the clicommand in rust soon changes from v1: * rename all occurences of 'comment' to 'notes' where possible (everywhere except the snapshots api of pbs) * split patches so that pbs ones could be applied later apply order/dependency: pbs patches (can be applied later): pve-manager 3/3 depends on pve-storage 4/4 depends on proxmxo-backup else: pve-manager 1/3 depends on pve-storage 1/4 pve-manager 2/3 depends on pve-storage 2,3/4 proxmox-backup: Dominik Csapak (1): client: add 'snapshot notes show/update' command src/bin/proxmox-backup-client.rs | 1 + src/bin/proxmox_backup_client/mod.rs | 2 + src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++ 3 files changed, 129 insertions(+) create mode 100644 src/bin/proxmox_backup_client/snapshot.rs pve-storage: Dominik Csapak (4): rename comment to notes api2/storage/content: change to volume_size_info and add return properties Storage/Plugin: add get/update_volume_comment and implement for dir Storage/PBSPlugin: implement get/update_volume_notes for pbs PVE/API2/Storage/Content.pm | 96 ++++++++++++++++++++++++++++++++++--- PVE/Storage.pm | 20 ++++++++ PVE/Storage/DirPlugin.pm | 30 ++++++++++++ PVE/Storage/PBSPlugin.pm | 22 ++++++++- PVE/Storage/Plugin.pm | 22 +++++++-- 5 files changed, 177 insertions(+), 13 deletions(-) pve-manager: Dominik Csapak (3): ui: change comment column to notes ui: add ability to show and edit comments for backups ui: enable notesedit for pbs www/manager6/grid/BackupView.js | 47 +++++++++++++++++++++++++++-- www/manager6/storage/Browser.js | 2 +- www/manager6/storage/ContentView.js | 12 ++++---- 3 files changed, 51 insertions(+), 10 deletions(-) -- 2.20.1