From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3EB9E62479 for ; Mon, 23 Nov 2020 14:21:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 343BE295EF for ; Mon, 23 Nov 2020 14:21:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 60E56295E5 for ; Mon, 23 Nov 2020 14:21:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2649D43F8C for ; Mon, 23 Nov 2020 14:21:51 +0100 (CET) Date: Mon, 23 Nov 2020 14:21:26 +0100 From: Oguz Bektas To: Proxmox VE development discussion Message-ID: <20201123132126.GC13623@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas , Proxmox VE development discussion References: <20201120093812.65554-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201120093812.65554-1-d.jaeger@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.499 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, importdisk.pm, nodes.pm, proxmox.com, drive.pm, qm.pm, import.pm, ovf.pm, qemu.pm] Subject: Re: [pve-devel] [PATCH qemu-server 0/1 v2] Importwizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 13:21:52 -0000 hi, here are some issues i've found: 1. actually depends on proxmox-widget-toolkit=2.3-10. with the newer widget toolkit, you will get an error on the console while going through the wizard, and it will be stuck at the 'Hard Disk' step 2. "Import Disk" menu doesn't show the "Use a storage as source" subitems unless you click back & forth between absolute path there are a few other small bugs that are related to widget toolkit, so this needs to be rebased and tested again. On Fri, Nov 20, 2020 at 10:38:06AM +0100, Dominic Jäger wrote: > v2: The first patches are untouched, i added two commits > - Importwizard: Add & remove disk buttons moved from bottom bar into the panel > -- This I was just working on > - fixed gui for importing a single disk; Thank you for the hint Oguz > -- As this is relatively important fix > > > Patch 4 (import vm) has already changed a lot of lines from patch 2 (import > disk), so it is chaotic and kind of requires "git diff > master..withChaoticPatchesApplied" instead of looking at individual patches > already. => Adding the fixes at the end doesn't make it worse than it already > is, I think. > > ########### > > As I've talked with Thomas & Dominik about the current state. > I cleaned up the worst chaos, but it's still very much work in progress. > > Nonetheless, if > - you have an .ovf > - and its disks somewhere on your server > - and are root > then you can click through the wizard and will have a VM > - that actually starts > - has all the disks automatically attached, converted etc. > - has hostname, cores, RAM like in the .ovf > so that's something, I think. > > > qemu-server: > > Dominic Jäger (1): > Move importdisk from qm to API > > PVE/API2/Qemu.pm | 209 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > PVE/API2/Qemu/Import.pm | 47 +++++++++++++ > PVE/CLI/qm.pm | 70 +++---------------- > PVE/QemuServer.pm | 18 ++++- > PVE/QemuServer/Drive.pm | 20 ++++++ > PVE/QemuServer/ImportDisk.pm | 85 ---------------------- > PVE/QemuServer/Makefile | 1 - > PVE/QemuServer/OVF.pm | 10 +-- > 8 files changed, 306 insertions(+), 154 deletions(-) > > Dominic Jäger (5): > gui: Hardware View: Add GUI for importdisk > gui: Add button & cmdmenu > gui: Add importdisk wizard > importwizard: Move buttons from bottom bar into panel > importdisk gui: Make storages selectable again > > PVE/API2/Nodes.pm | 48 +++++++ > www/manager6/Makefile | 2 + > www/manager6/Workspace.js | 15 ++ > www/manager6/form/ControllerSelector.js | 26 ++-- > www/manager6/node/CmdMenu.js | 12 ++ > www/manager6/qemu/HDEdit.js | 208 ++++++++++++++++++++++++--- > www/manager6/qemu/HardwareView.js | 24 ++++ > www/manager6/qemu/ImportWizard.js | 339 ++++++++++++++++++++++++++++++++++++++++++++ > www/manager6/qemu/MultiHDEdit.js | 290 +++++++++++++++++++++++++++++++++++++ > www/manager6/window/Wizard.js | 139 +++++++++--------- > 10 files changed, 1008 insertions(+), 95 deletions(-) > -- > 2.20.1 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel