From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 582F6617FE for ; Fri, 20 Nov 2020 15:29:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4420F12D34 for ; Fri, 20 Nov 2020 15:29:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D514212D2C for ; Fri, 20 Nov 2020 15:29:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8AD5A43D25 for ; Fri, 20 Nov 2020 15:29:13 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 20 Nov 2020 15:29:13 +0100 Message-Id: <20201120142913.12134-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.329 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix 'no iommu found' message for setups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2020 14:29:44 -0000 sometimes, the first device in the pci api call is not in a separate iommu group (see e.g. [0]), but it is active and should work instead of testing the first, test all, and only show the message if no device has a set iommu group Signed-off-by: Dominik Csapak --- www/manager6/qemu/PCIEdit.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js index b10326ba..72a355d0 100644 --- a/www/manager6/qemu/PCIEdit.js +++ b/www/manager6/qemu/PCIEdit.js @@ -93,8 +93,7 @@ Ext.define('PVE.qemu.PCIInputPanel', { return; } - var first = records[0]; - if (first.data.iommugroup === -1) { + if (records.every((val) => val.data.iommugroup === -1)) { // no iommu groups var warning = Ext.create('Ext.form.field.Display', { columnWidth: 1, -- 2.20.1