From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 52D4860FE9 for ; Thu, 19 Nov 2020 11:54:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EAC423EFB for ; Thu, 19 Nov 2020 11:54:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C17B823EF1 for ; Thu, 19 Nov 2020 11:54:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8458643BB5 for ; Thu, 19 Nov 2020 11:54:22 +0100 (CET) Date: Thu, 19 Nov 2020 11:54:20 +0100 From: Dominic =?iso-8859-1?Q?J=E4ger?= To: Proxmox VE development discussion Message-ID: <20201119105420.GA66443@mala.proxmox.com> References: <20201002082354.20204-1-a.lauterer@proxmox.com> <8ca313df-8bec-72da-3b2a-55a289b2a02d@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ca313df-8bec-72da-3b2a-55a289b2a02d@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.703 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [importdisk.pm] Subject: Re: [pve-devel] [PATCH v4 serries 0/4] disk reassign: add new feature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 10:54:53 -0000 Gave it a quick test: Moving some disks from one VM to another on a CIFS storage worked for me. Had to do some conflict resolution upon application though. => If (there is more feedback and) you rebase it, then I can test it (+ GUI) more thoroughly :) I would probably rename the parameter name drive_key for qm to something that already exists in our code, because to me it looks like we have different names for it already - Bus/Device in the GUI - the word (ide, scsi) is called Bus/Controller in man qm - the word is called interface (of a drive) in QemuServer.pm - we have $deviceid =~ m/^(virtio)(\d+)$/ in qemu-server, so the whole word+integer - and also "my $drive_id = "$drive->{interface}$drive->{index}"; - we have "{drive_name} may be used to specify ide0, scsi1, etc ..." in the (old) Importdisk.pm - and in ControllerSelector.js the first half is controller and the integer is deviceid And for me it would make sense to minimize those differences. Tested-by: Dominic Jäger On Fri, Oct 30, 2020 at 11:42:23AM +0100, Aaron Lauterer wrote: > Does anyone have time to take a look at the latest iteration of these patches? > > Thx :) > > On 10/2/20 10:23 AM, Aaron Lauterer wrote: > > deleted as well because it still had the VMID of VM A in it's name. > > > > To issue a reassign from the CLI run: > > > > qm reassign_disk > > > > where is the config key of the disk, e.g. ide0, scsi1 and so > > on. > > > > The following storage types are implemented at the moment: > > * dir based ones > > * CIFS