From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A4EBF69816 for ; Fri, 13 Nov 2020 15:12:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6588C1C33C for ; Fri, 13 Nov 2020 15:12:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6F5E1C32F for ; Fri, 13 Nov 2020 15:12:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 747D742775; Fri, 13 Nov 2020 15:12:11 +0100 (CET) Date: Fri, 13 Nov 2020 15:12:10 +0100 From: Stoiko Ivanov To: Thomas Legay Cc: Proxmox VE development discussion Message-ID: <20201113151210.02c9de62@rosa.proxmox.com> In-Reply-To: <20201112184839.391060-1-thomas@lgy.fr> References: <20201112184839.391060-1-thomas@lgy.fr> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm, proxmox.com] Subject: Re: [pve-devel] [Allow snapshot backup with glusterfs 0/1] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 14:12:42 -0000 Hi, Thank you for contributing to PVE! Could you explain what the patch fixes and why it works (would also be great to have that information in the commit-message)? I checked our bugzilla and the community forum, but could not find any recent issue regarding gluster and containers (I probably overlooked it). AFAICT the patch disables running syncfs(2) on the gluster fuse-mount used for containers. Does the syncfs call fail? What error do you get? The syncfs call is there to ensure that the backup is consistent as far as possible - so I would not disable it without rationale. On another note - we would need a signed CLA from you, in order to be able to include your code in our codebase - see [0]. Best Regards, stoiko [0] https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright On Thu, 12 Nov 2020 19:48:38 +0100 Thomas Legay wrote: > Thomas Legay (1): > Allow LXC snapshot backup with glusterfs mount point > > src/PVE/LXC.pm | 1 + > 1 file changed, 1 insertion(+) >