From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DD134696EC for ; Fri, 13 Nov 2020 14:17:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8C871B1AC for ; Fri, 13 Nov 2020 14:16:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7B8231B144 for ; Fri, 13 Nov 2020 14:16:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4294842DD9 for ; Fri, 13 Nov 2020 14:16:38 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 13 Nov 2020 14:16:13 +0100 Message-Id: <20201113131633.21915-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH-SERIES v3 manager] split up content view into a view for each type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 13:17:10 -0000 The goal of doing this is to have more flexibility/cleaner code for content-type-dependent features in the content view. Now only buttons that are useful for each content type are displayed. And it might make sense to display different columns for different content types, e.g. 'parent' for cloned VM/CT images. (see #16) API calls might be faster if only one type of content is requested. The obvious drawback is that there is no view with all contents anymore. The first patch is not directly related. It fixes the extension filters when selecting a file to upload. The last four patches are not directly related, but introduce grouping of backups and introduce the prune window, which was essentially copied from the PBS code. The prune window patch depends on this patch (otherwise it would error out when all numberfields are cleared): https://lists.proxmox.com/pipermail/pve-devel/2020-November/045916.html Changes from v2: * rebase on current master and deal with the new comment column * fix backup grouping for PBS storages * base prune window on the current prune window from PBS (there were some changes in the time since I sent v2) Fabian Ebner (20): fix extension filter for upload window config panel: allow new nodes to be added later storage panel/browser: use insertNodes function add CD ROM and lxc icons for treelist-item-icon use separate view for each content type remove the now unnecessary grouping by content type remove the now unneccessary content type column content view: allow specifying title bar elements for init turn {nodename,storage,sm} into object variables add upload button conditionally create and use TemplateView create and use BackupView get rid of unneccessary enableFn's create ImageView and use it for VM and CT images simplify reload call content view: allow specifying which columns to show on init group backups by backup groups in backup view allow child classes of ContentView to specify their own listeners add CSS for button in grid's group header backup view: add prune window www/css/ext6-pve.css | 28 ++ www/manager6/Makefile | 4 + www/manager6/panel/ConfigPanel.js | 93 ++--- www/manager6/storage/BackupView.js | 128 +++++++ www/manager6/storage/Browser.js | 97 ++++- www/manager6/storage/ContentView.js | 551 +++++++-------------------- www/manager6/storage/ImageView.js | 74 ++++ www/manager6/storage/TemplateView.js | 215 +++++++++++ www/manager6/window/Prune.js | 306 +++++++++++++++ 9 files changed, 1018 insertions(+), 478 deletions(-) create mode 100644 www/manager6/storage/BackupView.js create mode 100644 www/manager6/storage/ImageView.js create mode 100644 www/manager6/storage/TemplateView.js create mode 100644 www/manager6/window/Prune.js -- 2.20.1