From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 228766946E; Fri, 13 Nov 2020 10:38:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1EE6518953; Fri, 13 Nov 2020 10:38:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9A9D118915; Fri, 13 Nov 2020 10:38:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 426E44219A; Fri, 13 Nov 2020 10:38:53 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Fri, 13 Nov 2020 10:38:47 +0100 Message-Id: <20201113093852.28788-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.366 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [content.pm, pbsplugin.pm, storage.pm, mod.rs, plugin.pm, snapshot.rs, dirplugin.pm, proxmox-backup-client.rs] Subject: [pve-devel] [PATCH proxmox-backup/pve-storage/manager] show/edit backup comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 09:38:55 -0000 implement editing/showing comments (or notes) from pve side for directory and pbs storages i am not completely happy with the notes != comments mismatch but we are not even consistent within a product (e.g. description vs comment), so i am open to suggestions... pve-manager depends on new pve-storage, which depends on new proxmox-backup-client proxmox-backup: Dominik Csapak (2): client/http_client: add put method client: add 'snapshot notes show/update' command src/bin/proxmox-backup-client.rs | 1 + src/bin/proxmox_backup_client/mod.rs | 2 + src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++ src/client/http_client.rs | 9 ++ 4 files changed, 138 insertions(+) create mode 100644 src/bin/proxmox_backup_client/snapshot.rs pve-storage: Dominik Csapak (2): api2/storage/content: change to volume_size_info and add return properties Storage/Plugin: add get/update_volume_comment and implement for dir/pbs PVE/API2/Storage/Content.pm | 92 +++++++++++++++++++++++++++++++++++-- PVE/Storage.pm | 24 +++++++++- PVE/Storage/DirPlugin.pm | 30 ++++++++++++ PVE/Storage/PBSPlugin.pm | 20 ++++++++ PVE/Storage/Plugin.pm | 12 +++++ 5 files changed, 171 insertions(+), 7 deletions(-) pve-manager; Dominik Csapak (1): ui: add ability to show and edit comments for backups www/manager6/grid/BackupView.js | 43 ++++++++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-) -- 2.20.1